Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpes tweaks #136

Merged
merged 9 commits into from
Oct 5, 2023
Merged

Mpes tweaks #136

merged 9 commits into from
Oct 5, 2023

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jul 30, 2023

Some further improvements for the mpes workflow an loader

@coveralls
Copy link
Collaborator

coveralls commented Jul 30, 2023

Pull Request Test Coverage Report for Build 6421333972

  • 50 of 52 (96.15%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 90.556%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/processor.py 1 2 50.0%
sed/loader/mpes/loader.py 21 22 95.45%
Files with Coverage Reduction New Missed Lines %
sed/calibrator/energy.py 2 91.86%
Totals Coverage Status
Change from base Build 6285960524: 0.03%
Covered Lines: 4219
Relevant Lines: 4659

💛 - Coveralls

@rettigl
Copy link
Member Author

rettigl commented Sep 25, 2023

This PR contains a few usefull additions mostly for mpes:

  • print some output from the correction workflows into widgets, as normal output is not shown in jupyter lab after a cell has been executed
  • revert the momentum correction back before successive application of pose corrections
  • add "runs" implementation for the mpes loader
  • add option to pass a eln file to the nexus converter, without providing the complete file list

I want to merge it before it grows any bigger yet, a review should be still quick and feasible.

Copy link
Member

@steinnymir steinnymir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like mostly MPES related changes, so nothing against that.
Only wondering why limiting the jupyter version.

pyproject.toml Outdated Show resolved Hide resolved
@rettigl rettigl merged commit 8f49f40 into main Oct 5, 2023
4 checks passed
@rettigl rettigl deleted the mpes-tweaks branch October 5, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants