Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config file simplified and unnecessary module removed #111

Merged
merged 14 commits into from
Aug 12, 2023
Merged

Conversation

zain-sohail
Copy link
Member

No description provided.

@rettigl
Copy link
Member

rettigl commented Mar 23, 2023

I'm fine with renaming / removing this as a module. However, please also fix the test, take care of linting, and update the docs.

@zain-sohail
Copy link
Member Author

I'm fine with renaming / removing this as a module. However, please also fix the test, take care of linting, and update the docs.

@rettigl yes that's exactly why i closed the PR for now.

@zain-sohail zain-sohail reopened this Mar 31, 2023
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with renaiming the module, but not with changing its functionality. What is the reason for it? I very much opt for keeping the resusability of the functions, as we might want to combine different levels of config in the future.

sed/__init__.py Outdated Show resolved Hide resolved
sed/core/config.py Outdated Show resolved Hide resolved
sed/core/config.py Outdated Show resolved Hide resolved
sed/core/default.yaml Outdated Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
sed/__init__.py Outdated Show resolved Hide resolved
sed/core/default.yaml Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jul 19, 2023

Pull Request Test Coverage Report for Build 5822779127

  • 112 of 184 (60.87%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 73.547%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/metadata.py 1 2 50.0%
sed/core/config.py 74 95 77.89%
sed/core/processor.py 7 57 12.28%
Totals Coverage Status
Change from base Build 5598521386: -0.9%
Covered Lines: 2961
Relevant Lines: 4026

💛 - Coveralls

@rettigl
Copy link
Member

rettigl commented Jul 19, 2023

I updated this PR to include loading functionality for a hierarchy of config files, from the given one, to a file in the current folder, to a user-file in the user's home directory, down to the default config.
I also included functionality to write out the calibration and correction parameters to the per-folder config file, as discussed in issue #121
@steinnymir @zainsohail04 please re-review

@rettigl rettigl force-pushed the config_update branch 2 times, most recently from be579f5 to d477f77 Compare July 30, 2023 23:19
sed/core/config.py Show resolved Hide resolved
sed/core/config.py Outdated Show resolved Hide resolved
sed/core/config.py Show resolved Hide resolved
sed/core/config.py Show resolved Hide resolved
sed/core/config.py Show resolved Hide resolved
@rettigl
Copy link
Member

rettigl commented Aug 10, 2023

@zainsohail04 please check if the updated documentation makes now sense to you...

@zain-sohail
Copy link
Member Author

@zainsohail04 please check if the updated documentation makes now sense to you...

Thank you for the updates. It's all understandable now.

@zain-sohail zain-sohail removed the request for review from steinnymir August 12, 2023 18:18
@zain-sohail zain-sohail merged commit 2e06563 into main Aug 12, 2023
@zain-sohail zain-sohail deleted the config_update branch August 12, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants