-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config file simplified and unnecessary module removed #111
Conversation
I'm fine with renaming / removing this as a module. However, please also fix the test, take care of linting, and update the docs. |
@rettigl yes that's exactly why i closed the PR for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with renaiming the module, but not with changing its functionality. What is the reason for it? I very much opt for keeping the resusability of the functions, as we might want to combine different levels of config in the future.
Pull Request Test Coverage Report for Build 5822779127
💛 - Coveralls |
I updated this PR to include loading functionality for a hierarchy of config files, from the given one, to a file in the current folder, to a user-file in the user's home directory, down to the default config. |
be579f5
to
d477f77
Compare
@zainsohail04 please check if the updated documentation makes now sense to you... |
Thank you for the updates. It's all understandable now. |
No description provided.