Skip to content

Commit

Permalink
remove code analysis section for now and use old way of running linter
Browse files Browse the repository at this point in the history
  • Loading branch information
zain-sohail committed Oct 13, 2023
1 parent 132f7cc commit 4e99f9d
Show file tree
Hide file tree
Showing 3 changed files with 159 additions and 10 deletions.
14 changes: 10 additions & 4 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# This workflow will install Python dependencies, lint and run tests with a single version of Python
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
# TODO: switch to the cached version
name: linting

on: [push]
Expand All @@ -20,6 +19,13 @@ jobs:
with:
python-version: 3.8
poetry-version: 1.2.2
- uses: advanced-security/python-lint-code-scanning-action@v1
with:
linter: ${{ matrix.linter }}
- name: pycodestyle
run:
poetry run pycodestyle sed tests
- name: pylint
run:
poetry run pyling sed tests
- name: mypy
run:
poetry run mypy sed tests

147 changes: 145 additions & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,14 @@ sphinx-autodoc-typehints = {version = ">1.17.0", extras = ["docs"], optional = t
notebook = ["jupyter", "ipykernel"]
docs = ["Sphinx", "sphinx-rtd-theme", "tomlkit", "sphinx-autodoc-typehints"]

[tool.poetry.dev-dependencies]
[tool.poetry.group.dev.dependencies]
pytest = "^7.0.1"
pytest-cov = "^3.0.0"
pytest-xdist = "^2.5.0"
pytest-clarity = "^1.0.1"
pylint = "^3.0.1"
mypy = "^1.6.0"
pycodestyle = "^2.11.1"

[build-system]
requires = ["poetry-core>=1.0.0"]
Expand All @@ -63,9 +66,6 @@ omit = [
ignore = ["fixme", "too-many-branches", "too-many-locals", "too-many-statements", "too-many-arguments", "too-many-lines", "too-many-public-methods", "too-many-instance-attributes", "too-few-public-methods"]
good-names = "i,j,k,ex,x,y,t,k,v,ax,df,ec,mc,dc,ct"

[tool.pylint.main]
ignore-paths = ["docs"]

[tool.mypy]
ignore-missing-imports = true
follow-imports = "silent"
Expand Down

0 comments on commit 4e99f9d

Please sign in to comment.