Skip to content

Commit

Permalink
fix small error and bypass push to main to test (#222)
Browse files Browse the repository at this point in the history
* fix small error and bypass push to main to test

* update name of mulitversion workflow, and fix badges in readme.md

* Parallelize pylint

* Limit multitesting to main again

* remove workflow running on PR to other branches

---------

Co-authored-by: rettigl <[email protected]>
Co-authored-by: Laurenz Rettig <[email protected]>
  • Loading branch information
3 people authored Oct 29, 2023
1 parent 2a99e33 commit 4ccf011
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ jobs:
- name: pylint
if: ${{ always() }}
run:
poetry run pylint --good-names=i,j,k,ex,x,y,t,k,v,ax,df,ec,mc,dc,ct --disable=fixme,too-many-branches,too-many-locals,too-many-statements,too-many-arguments,too-many-lines,too-many-public-methods,too-many-instance-attributes,too-few-public-methods sed tests
poetry run pylint -j 0 --good-names=i,j,k,ex,x,y,t,k,v,ax,df,ec,mc,dc,ct --disable=fixme,too-many-branches,too-many-locals,too-many-statements,too-many-arguments,too-many-lines,too-many-public-methods,too-many-instance-attributes,too-few-public-methods sed tests
- name: mypy
if: ${{ always() }}
run:
poetry run mypy --ignore-missing-imports --follow-imports=silent --no-strict-optional sed tests
poetry run mypy --ignore-missing-imports --follow-imports=silent --no-strict-optional sed tests
12 changes: 9 additions & 3 deletions .github/workflows/testing_coverage.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
name: pytest and coverage report

# Triggers the workflow on push and PR for all branches
on: [push, pull_request]
# Triggers the workflow on push for all branches and PR only for main
on:
push:
branches:
- '*'
pull_request:
branches:
- main

jobs:
pytest:
Expand Down Expand Up @@ -30,4 +36,4 @@ jobs:
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
file: ./cobertura.xml
file: ./cobertura.xml
4 changes: 2 additions & 2 deletions .github/workflows/testing_multiversion.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pytest multiversion
name: unit tests [Python 3.8|3.9|3.10]

on:
push:
Expand Down Expand Up @@ -27,4 +27,4 @@ jobs:
# Use cached python and dependencies, install poetry
- name: Run tests on python ${{matrix.python-version}}
run: |
poetry run pytest--full-trace --show-capture=no -sv -n auto tests/
poetry run pytest --full-trace --show-capture=no -sv -n auto tests/
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# sed
[![Documentation Status](https://readthedocs.org/projects/sed/badge/?version=latest)](https://sed.readthedocs.io/en/latest/?badge=latest)
![](https://github.com/OpenCOMPES/sed/actions/workflows/pylint.yml/badge.svg?branch=main)
![](https://github.com/OpenCOMPES/sed/actions/workflows/pytest.yml/badge.svg?branch=main)
![](https://github.com/OpenCOMPES/sed/actions/workflows/linting.yml/badge.svg?branch=main)
![](https://github.com/OpenCOMPES/sed/actions/workflows/testing_multiversion.yml/badge.svg?branch=main)
![](https://img.shields.io/pypi/pyversions/sedprocessor)
![](https://img.shields.io/pypi/l/sedprocessor)
![](https://img.shields.io/pypi/v/sedprocessor)
Expand Down

0 comments on commit 4ccf011

Please sign in to comment.