Blur LedWidgets when stale #1849
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 519 519
Lines 40774 40774
=======================================
+ Hits 32444 32446 +2
+ Misses 8330 8328 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -105,4 +112,8 @@ export default { | |||
| background-color: var(--color); | |||
| border-radius: 50%; | |||
| } | |||
| .stale { | |||
| filter: blur(2px); | |||
| opacity: 0.6; | |||
There was a problem hiding this comment.
Should probably add brightness(0.6) to the filter instead of opacity - that will just darken it instead of giving it a dark blue tint, which should help with colorblindness and future-proofing for if/when we add themes
The customer explicitly didn't want that: 'We would like to request an enhancement to this widget such that the color of the LED light is turned slightly gray when the telemetry point it is tied to goes stale. This way, the viewer can still observe the current state, as well as whether or not that state is stale.' Instead of slightly grey I blur the widget and change the brightness to indicate stale. This still allows them to know what the last value was. Plus purple could be a valid color. |
|
I don't like the inconsistency with everything else. |
|
|
closes #1683