Improve package install in openc3cli. Includes fix to python install #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
==========================================
- Coverage 79.57% 79.56% -0.02%
==========================================
Files 517 517
Lines 40737 40737
==========================================
- Hits 32418 32412 -6
- Misses 8319 8325 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
jmthomas
approved these changes
Jan 2, 2025
| OpenC3::PythonPackageModel.install(filename, scope: scope) | ||
| process_name = OpenC3::PythonPackageModel.install(filename, scope: scope) | ||
| print "Installing..." | ||
| wait_process_complete_internal(process_name, scope: scope) |
There was a problem hiding this comment.
How did this fix the python install? It wasn't waiting for complete and then the process died before it was done?
There was a problem hiding this comment.
This cleaned up leaving process status as running forever, because the process that was monitor complete had died.
ryan-pratt
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.