Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert for unsupported browsers #1802

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Alert for unsupported browsers #1802

merged 2 commits into from
Jan 2, 2025

Conversation

ryan-pratt
Copy link
Contributor

closes #1762

@ryan-pratt ryan-pratt requested a review from ryanmelt December 30, 2024 22:18
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (ea0f8c9) to head (5fc2130).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1802      +/-   ##
==========================================
- Coverage   79.57%   79.56%   -0.02%     
==========================================
  Files         517      517              
  Lines       40737    40737              
==========================================
- Hits        32418    32413       -5     
- Misses       8319     8324       +5     
Flag Coverage Δ
python 84.26% <ø> (-0.04%) ⬇️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should also at least include Edge without errors. Maybe Safari too.

@ryan-pratt ryan-pratt merged commit f37730f into main Jan 2, 2025
27 of 28 checks passed
@ryan-pratt ryan-pratt deleted the browser-alert branch January 2, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better incompatible browser experience
2 participants