Skip to content

Fix write_conversion of default string to int and don't range check strings #3169

Fix write_conversion of default string to int and don't range check strings

Fix write_conversion of default string to int and don't range check strings #3169

Triggered via pull request January 18, 2025 20:00
Status Success
Total duration 33m 42s
Artifacts 1

playwright.yml

on: pull_request
openc3-build-test
31m 48s
openc3-build-test
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 6 warnings, and 3 notices
[chromium] › command-sender.spec.ts:408:5 › hazardous commands from history: playwright/tests/command-sender.spec.ts#L421
1) [chromium] › command-sender.spec.ts:408:5 › hazardous commands from history ─────────────────── Error: Timed out 10000ms waiting for expect(locator).toContainText(expected) Locator: locator('main') Expected string: "cmd(\"INST ASCIICMD with STRING 'ARM LASER', BINARY 0xDEADBEEF, ASCII '0xDEADBEEF'\")" Received string: "Select TargetINSTSelect TargetSelect PacketASCIICMDSelect PacketSendDescription: Enumerated ASCII command Parameters NameValue or StateUnitsRangeDescriptionSTRINGARM LASERN/AEnumerated string parameterBINARYN/ABinary stringASCIIN/AASCII stringStatus: Editable Command History: (Pressing Enter on the line re-executes the command) 1cmd(\"INST CLEAR\")  ההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXLOCAL CMDSENDERASCIICMD:" Call log: - expect.toContainText with timeout 10000ms - waiting for locator('main') 14 × locator resolved to <main class="v-main">…</main> - unexpected value "Select TargetINSTSelect TargetSelect PacketASCIICMDSelect PacketSendDescription: Enumerated ASCII command Parameters NameValue or StateUnitsRangeDescriptionSTRINGARM LASERN/AEnumerated string parameterBINARYN/ABinary stringASCIIN/AASCII stringStatus: Editable Command History: (Pressing Enter on the line re-executes the command) 1cmd("INST CLEAR")  ההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההההXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXLOCAL CMDSENDERASCIICMD:" 419 | await page.locator('[data-test="select-send"]').click() 420 | await page.getByRole('dialog').getByRole('button', { name: 'Send' }).click() > 421 | await expect(page.locator('main')).toContainText( | ^ 422 | "cmd(\"INST ASCIICMD with STRING 'ARM LASER', BINARY 0xDEADBEEF, ASCII '0xDEADBEEF'\")", 423 | ) 424 | // Re-execute commands from history at /home/runner/work/cosmos/cosmos/playwright/tests/command-sender.spec.ts:421:38
[chromium] › script-runner/api.spec.ts:307:5 › test ruby screen apis: playwright/tests/script-runner/api.spec.ts#L269
2) [chromium] › script-runner/api.spec.ts:307:5 › test ruby screen apis ────────────────────────── Error: Timed out 10000ms waiting for expect(locator).toHaveValue(expected) Locator: locator('[data-test=state] input') Expected string: "running" Received string: "waiting 0s" Call log: - expect.toHaveValue with timeout 10000ms - waiting for locator('[data-test=state] input') 6 × locator resolved to <input readonly size="1" type="text" id="input-13" value="Connecting..." class="v-field__input" aria-describedby="input-13-messages"/> - unexpected value "Connecting..." 3 × locator resolved to <input readonly size="1" type="text" id="input-13" value="waiting 0s" class="v-field__input" aria-describedby="input-13-messages"/> - unexpected value "waiting 0s" - locator resolved to <input readonly size="1" type="text" id="input-13" value="waiting 1s" class="v-field__input" aria-describedby="input-13-messages"/> - unexpected value "waiting 1s" - locator resolved to <input readonly size="1" type="text" id="input-13" value="waiting 0s" class="v-field__input" aria-describedby="input-13-messages"/> - unexpected value "waiting 0s" - locator resolved to <input readonly size="1" type="text" id="input-13" value="waiting 1s" class="v-field__input" aria-describedby="input-13-messages"/> - unexpected value "waiting 1s" - locator resolved to <input readonly size="1" type="text" id="input-13" value="waiting 2s" class="v-field__input" aria-describedby="input-13-messages"/> - unexpected value "waiting 2s" - locator resolved to <input readonly size="1" type="text" id="input-13" value="waiting 0s" class="v-field__input" aria-describedby="input-13-messages"/> - unexpected value "waiting 0s" 267 | }, 268 | ) > 269 | await expect(page.locator('[data-test=state] input')).toHaveValue('running') | ^ 270 | // script displays INST ADCS 271 | await expect(page.getByText(`${target} ADCS`, { exact: true })).toBeVisible() 272 | // script displays INST HS at testScreenApis (/home/runner/work/cosmos/cosmos/playwright/tests/script-runner/api.spec.ts:269:57) at /home/runner/work/cosmos/cosmos/playwright/tests/script-runner/api.spec.ts:308:3
openc3-build-test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: playwright/[chromium] › admin/plugins.spec.ts#L1
playwright/[chromium] › admin/plugins.spec.ts took 2.4m
Slow Test: playwright/[chromium] › script-runner/suite.spec.ts#L1
playwright/[chromium] › script-runner/suite.spec.ts took 1.9m
Slow Test: playwright/[chromium] › limits-monitor.spec.ts#L1
playwright/[chromium] › limits-monitor.spec.ts took 1.6m
Slow Test: playwright/[chromium] › tlm-viewer.spec.ts#L1
playwright/[chromium] › tlm-viewer.spec.ts took 1.1m
Slow Test: playwright/[chromium] › bucket-explorer.spec.ts#L1
playwright/[chromium] › bucket-explorer.spec.ts took 1.1m
🎭 Playwright Run Summary
211 did not run
🎭 Playwright Run Summary
2 flaky [chromium] › command-sender.spec.ts:408:5 › hazardous commands from history ──────────────────── [chromium] › script-runner/api.spec.ts:307:5 › test ruby screen apis ─────────────────────────── 1 skipped 207 passed (22.3m)
🎭 Playwright Run Summary
2 passed (6.1s)

Artifacts

Produced during runtime
Name Size
playwright
19.1 MB