Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasForceSpecificEquation #280

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

fjclark
Copy link
Collaborator

@fjclark fjclark commented Jan 29, 2025

This now returns true if there is a default equation for the force.

If this is to fix a bug...

This pull request fixes issue #279 (I have confirmed that the script supplied there now shows equal energies at lambda = 0 and lambda = 1).

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): y
  • I confirm that I have added a changelog entry to the changelog (we will add a link to this PR as part of the review): y
  • I confirm that I have permission to release this code under the GPL3 license: y

Suggested reviewers:

@chryswoods, @lohedges

Thanks!

This now returns true if there is a default equation for the force.
@lohedges
Copy link
Contributor

Thanks, @fjclark. Could you add an entry to the bottom of the CHANGELOG section for the 2023.4.0 release.

@lohedges
Copy link
Contributor

Thanks. It looks like your branch must be behind devel (I guess you branched prior to my merge earlier), hence the conflict with the CHANGELOG file.

@fjclark
Copy link
Collaborator Author

fjclark commented Jan 30, 2025

Ah, sorry. I've updated now.

Copy link
Contributor

@lohedges lohedges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fjclark. Good catch.

@lohedges lohedges merged commit b3a566b into OpenBioSim:devel Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants