[BUG] AmberRst7 parser fails if there is a blank line at the end of file

[lohedges]

The SireIO::AmberRst7 parser fails if there is a blank line at the end. The line can contain valid data, which it is trying to parse. We should check for an empty line and skip.

[lohedges]

Actually, the code is doing it's job. The issue is that this was a 2 atom molecule, so there would be two lines if there were coordinates and velocities. Since the second line is blank, it is failing to read the velocities. There's no valid way to know that the velocities should be missing, since it is expecting them to be present given the size of the file. If the molecule was larger and a blank line existed, then all would be okay since it wouldn't even attempt to parse the velocities since there aren't enough lines.

[chryswoods]

This is one of the many reasons why I don't like AmberRst7. The NetCDF-based formats are much better.

[lohedges]

Agreed. I think this was a rare edge case where someone happened to be testing conversion of a problem molecule to make sure that information was preserved. I doubt this would have tripped us up in practice.