You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When matching atoms to the perturbation template the current code incorrectly uses next to skip the atom in the case of a mismatch (see here). This will raise cause an Exception to be raised if the first atom in the molecule isn't in the atoms section of the pert file, i.e. it is unperturbed. However, if there is a later mismatch, then the wrong values of the end state charge,LJ, and ambertype will be applied to the atom. The solution is to replace next with continue.
The text was updated successfully, but these errors were encountered:
On a related not, I'm not sure if the error message that is printed when the atom is skipped is too useful. (Perhaps this is for debugging.) Since the atom records in the pert file only contains perturbing atoms, there will likely be many situations where atoms in the topology aren't matched. Perhaps there could be a verbose mode that prints what did and didn't match so that the user can cross-reference if they wish?
When matching atoms to the perturbation template the current code incorrectly uses
next
to skip the atom in the case of a mismatch (see here). This will raise cause anException
to be raised if the first atom in the molecule isn't in theatoms
section of the pert file, i.e. it is unperturbed. However, if there is a later mismatch, then the wrong values of the end statecharge
,LJ
, andambertype
will be applied to the atom. The solution is to replacenext
withcontinue
.The text was updated successfully, but these errors were encountered: