Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI for new release process #34

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Update CI for new release process #34

merged 4 commits into from
Apr 14, 2023

Conversation

lohedges
Copy link
Contributor

This PR mirrors the CI changes to Sire, as required for the new release process. Since, unlike Sire, BioSimSpace is not a standalone package, i.e. it requires Sire as a base, there are a few subtle differences:

  • The label of the openbiosim channel used during a build matches the branch against which the build is based, i.e. the main label for main, and dev for devel.
  • Packages built against a particular branch are only pushed to the channel label associated with this branch, i.e. same as above, main for main and dev for devel. This is because so we can guarantee compatibility between packages with a given label. Versioning should make this okay regardless, but this will ensure we don't have any headaches.

Assuming this works, I'll merge into devel and main. It's possible that I might need to fix minor issues with the CI scripts for the first builds there, but hopefully things are okay since I followed the same procedure as Sire.

I've also update the setup.py file for BioSimSpace so that it can handle .dev packages when making version comparisons.

Checklist

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

Suggested reviewers:

@chryswoods

@lohedges lohedges requested a review from chryswoods April 14, 2023 12:04
@lohedges lohedges temporarily deployed to biosimspace-build April 14, 2023 12:04 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build April 14, 2023 12:04 — with GitHub Actions Inactive
@lohedges
Copy link
Contributor Author

I just remembered that tests might fail because of the AmberPrm issue. Also, I've not thought about how to version Sire correctly for the different branches, i.e. devel should now require 2023.3.0.dev, whereas main will need 2023.2.2 when that's released.

@lohedges
Copy link
Contributor Author

Yes, the tests are segfaulting. I'll update the version Sire version requirement for this PR to devel, which will need to be modified when PR'ing into main.

@lohedges lohedges temporarily deployed to biosimspace-build April 14, 2023 12:57 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build April 14, 2023 12:57 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build April 14, 2023 12:57 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build April 14, 2023 12:57 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build April 14, 2023 12:57 — with GitHub Actions Inactive
Copy link
Contributor

@chryswoods chryswoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants