-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronise with Exscientia fork #31
Conversation
Sync with OpenBioSim/devel [closes #416]
Co-authored-by: William (Zhiyi) Wu <[email protected]>
* update * update * update * update * update * update * update * update * fix typo * update * update * update test * update --------- Co-authored-by: William (Zhiyi) Wu <[email protected]>
Looks like actions is down at the moment. Hopefully the CI will automatically trigger when it comes back up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to go :-)
The usual case of sandpit tests not being guarded against missing packages. I thought I had checked, but apparently not. Will fix and re-run the CI overnight. Just need to update the CHANGELOG tomorrow and make sure tutorials and demos still work as expected. Almost there. |
This PR synchronises the repository with the Exscientia fork. I've needed to manually fix some files since their fork is still based on the old Michellab repository, so some files were more recent due to me backporting updates from here to that repo. (Note that the first 7 commits are me backporting the 2023.1.0 release to
michellab
, which I have had to undo.)In future I think that this should be handled as a PR from their side, since the checklist below is a little meaningless if I am filling it on their behalf.
(At present they are still forked from
michellab
. Their is a GitHub process to transfer a fork, but it seems like their ticket hasn't been dealt with yet. A quicker solution might be for them to delete their existing fork (keeping a local copy), fork the new repository, update their local remote, then re-push all feature branches and tags to the new fork.)Checklist:
devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]Suggested reviewers:
@chryswoods