Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: addtoconfig is not a function in _amber.py, add to protocol d… #220

Merged
merged 1 commit into from
Dec 8, 2023
Merged

bugfix: addtoconfig is not a function in _amber.py, add to protocol d… #220

merged 1 commit into from
Dec 8, 2023

Conversation

annamherz
Copy link
Contributor

…ict instead

Hello! This is a PR to fix a small bug in the amber config file writing. As there is no addToConfig() function, this throws an error. Adding to the protocol dict instead fixes this line.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): y
  • I confirm that I have permission to release this code under the GPL3 license: y

Suggested reviewers:

@lohedges

@annamherz annamherz temporarily deployed to biosimspace-build December 8, 2023 14:04 — with GitHub Actions Inactive
@annamherz annamherz temporarily deployed to biosimspace-build December 8, 2023 14:04 — with GitHub Actions Inactive
@annamherz annamherz temporarily deployed to biosimspace-build December 8, 2023 14:04 — with GitHub Actions Inactive
@annamherz annamherz temporarily deployed to biosimspace-build December 8, 2023 14:04 — with GitHub Actions Inactive
@annamherz annamherz temporarily deployed to biosimspace-build December 8, 2023 14:04 — with GitHub Actions Inactive
@lohedges lohedges added the bug Something isn't working label Dec 8, 2023
@lohedges lohedges self-requested a review December 8, 2023 14:22
lohedges
lohedges approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@lohedges lohedges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @annamherz!

@lohedges lohedges merged commit c46fd7c into OpenBioSim:devel Dec 8, 2023
5 checks passed
lohedges added a commit that referenced this pull request Dec 11, 2023
@lohedges
Backport fix from PR #220. [ci skip]
565e0d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohedges lohedges lohedges approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annamherz @lohedges