Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Is there a bug for funnel correction when estimating the average area of the restraint? #246

Closed
zheqiang-zhong opened this issue Feb 22, 2024 · 1 comment · Fixed by #247
Assignees
Labels
bug Something isn't working

Comments

@zheqiang-zhong
Copy link

Dear Developer,

The line when calculating the average area is:
# Estimate the average area of the restraint (in Angstrom squared). area = (volume / proj_max).angstroms2()

Do you think it should be:
# Estimate the average area of the restraint (in Angstrom squared). area = (volume / (proj_max - proj_min)).angstroms2()

to get the correct surface of the cylinder.

Thanks and best regards,

@zheqiang-zhong zheqiang-zhong added the bug Something isn't working label Feb 22, 2024
@lohedges lohedges self-assigned this Feb 22, 2024
@lohedges
Copy link
Contributor

Thanks for reporting, I believe you are correct. This was adapted from @dlukauskis' original analysis notebook, which I can't seem to find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants