Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] readPerturbableSystem needs to remove shared system properties #241

Closed
lohedges opened this issue Feb 19, 2024 · 0 comments · Fixed by #244
Closed

[BUG] readPerturbableSystem needs to remove shared system properties #241

lohedges opened this issue Feb 19, 2024 · 0 comments · Fixed by #244
Assignees
@lohedges
Labels
bug Something isn't working

Comments

@lohedges
Copy link
Contributor

Like BioSimspace.IO.readMolecules, the BioSimSpace.IO.readPerturbableSystem function needs to remove any shared properties that are automatically added by Sire. These cause issues when combining molecules into other systems.
@lohedges lohedges added the bug Something isn't working label Feb 19, 2024
@lohedges lohedges self-assigned this Feb 19, 2024
lohedges added a commit that referenced this issue Feb 19, 2024
@lohedges
Remove shared properties when loading perturbable systems.
1cfa0bd 
[closes #241]
@lohedges lohedges mentioned this issue Feb 19, 2024
Merged
lohedges added a commit that referenced this issue Feb 19, 2024
@lohedges
Merge pull request #244 from OpenBioSim/fix_241-243
d94c19b 
Fix issues #241, #242, and #243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lohedges lohedges

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues #241, #242, and #243 OpenBioSim/biosimspace
1 participant
@lohedges