Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove redundant __neq__ operator for BioSImSpace.Types.Type #200

Closed
lohedges opened this issue Nov 10, 2023 · 0 comments · Fixed by #201
Closed

[BUG] Remove redundant __neq__ operator for BioSImSpace.Types.Type #200

lohedges opened this issue Nov 10, 2023 · 0 comments · Fixed by #201
Labels
bug Something isn't working exscientia Related to work with Exscientia

Comments

@lohedges
Copy link
Contributor

There is a mistake in the BioSimSpace.Types.Type.__ne__ operator. However, it is completely redundant since Python 3 will just negate __eq__.
@lohedges lohedges added bug Something isn't working exscientia Related to work with Exscientia labels Nov 10, 2023
lohedges added a commit that referenced this issue Nov 10, 2023
@lohedges
Remove redundant __ne__ operator. [closes #200]
e58a9c8
@lohedges lohedges mentioned this issue Nov 10, 2023
Merged
lohedges added a commit that referenced this issue Nov 10, 2023
@lohedges
Merge pull request #201 from OpenBioSim/fix_200
621149b 
Fix issue #200
lohedges added a commit that referenced this issue Nov 13, 2023
@lohedges
Backport fix from PR #200. [ci skip]
d2da218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working exscientia Related to work with Exscientia
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #200 OpenBioSim/biosimspace
1 participant
@lohedges