Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Velocity property for perturbable molecules not checked when making sure all molecules have velocities #192

Closed
lohedges opened this issue Oct 27, 2023 · 0 comments · Fixed by #193
Closed

[BUG] Velocity property for perturbable molecules not checked when making sure all molecules have velocities #192

lohedges opened this issue Oct 27, 2023 · 0 comments · Fixed by #193
Labels
bug Something isn't working

Comments

@lohedges
Copy link
Contributor

When combining molecules, velocities are removed if not all molecules have the property. However, for perturbable molecules, the property will be named velocity0 and velocity1, so needs to be checked independently.
@lohedges lohedges added the bug Something isn't working label Oct 27, 2023
lohedges added a commit that referenced this issue Oct 27, 2023
@lohedges
Check perturbable molecules for velocity property. [closes #192]
f234669
@lohedges lohedges mentioned this issue Oct 30, 2023
Merged
lohedges added a commit that referenced this issue Oct 31, 2023
@lohedges
Merge pull request #193 from OpenBioSim/fix_192
4b0ba24 
Fix issue #192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #192 OpenBioSim/biosimspace
1 participant
@lohedges