Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test csvtojson in CI #120

Closed
musoke opened this issue Jun 7, 2023 · 0 comments · Fixed by #133
Closed

test csvtojson in CI #120

musoke opened this issue Jun 7, 2023 · 0 comments · Fixed by #133
Labels
enhancement New feature or request
Milestone
Next

Comments

@musoke
Copy link
Collaborator

musoke commented Jun 7, 2023

Currently https://github.com/OpenBeta/sandbag/blob/f3e46f8d6855a614cdf59138d0b9d9829f9efcca/src/data/csvtojson.ts is only run during development. It has no tests in CI.
@musoke musoke added this to the Next milestone Jun 7, 2023
@musoke musoke mentioned this issue Jun 7, 2023
Open
@musoke musoke added the enhancement New feature or request label Jun 7, 2023
@musoke musoke mentioned this issue Jun 7, 2023
Closed
@musoke musoke mentioned this issue Jun 20, 2023
Closed
3 tasks
musoke added a commit to musoke/sandbag that referenced this issue Jun 28, 2023
@musoke
test: Add tests of csvtojson
a2a09f9 
`src/data/csvtojson.ts` is a script used to convert CSV tables of grades
to JSON files used by sandbag at run time.  The script is not tested in
CI, so it is not obvious if it is broken, or if someone forgot to run
it when changing grade tables.

Add tests of this script.
Also check that it does not change the correspondning JSON files during
testing.

Fixes: OpenBeta#120
musoke added a commit to musoke/sandbag that referenced this issue Jun 28, 2023
@musoke
test: Add tests of csvtojson
79f75a1 
`src/data/csvtojson.ts` is a script used to convert CSV tables of grades
to JSON files used by sandbag at run time.  The script is not tested in
CI, so it is not obvious if it is broken, or if someone forgot to run
it when changing grade tables.

Add tests of this script.
Also check that it does not change the correspondning JSON files during
testing.

Fixes: OpenBeta#120
musoke added a commit to musoke/sandbag that referenced this issue Jun 28, 2023
@musoke
test: Add tests of csvtojson
e6d7344 
`src/data/csvtojson.ts` is a script used to convert CSV tables of grades
to JSON files used by sandbag at run time.  The script is not tested in
CI, so it is not obvious if it is broken or if someone forgot to run it
while changing grade tables.

Add tests of this script.
Also check that it does not change the corresponding JSON files during
testing.

Fixes: OpenBeta#120
@musoke musoke mentioned this issue Jun 28, 2023
Merged
musoke added a commit to musoke/sandbag that referenced this issue Jun 28, 2023
@musoke
test: Add tests of csvtojson
0a1015f 
`src/data/csvtojson.ts` is a script used to convert CSV tables of grades
to JSON files used by sandbag at run time.  The script is not tested in
CI, so it is not obvious if it is broken or if someone forgot to run it
while changing grade tables.

Add tests of this script.
Also check that it does not change the corresponding JSON files during
testing.

Fixes: OpenBeta#120
musoke added a commit to musoke/sandbag that referenced this issue Jun 28, 2023
@musoke
test: Add tests of csvtojson
2e6e532 
`src/data/csvtojson.ts` is a script used to convert CSV tables of grades
to JSON files used by sandbag at run time.  The script is not tested in
CI, so it is not obvious if it is broken or if someone forgot to run it
while changing grade tables.

Add tests of this script.
Also check that it does not change the corresponding JSON files during
testing.

Fixes: OpenBeta#120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

Test and refactor csvtojson musoke/sandbag
1 participant
@musoke