-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process widget data in background when widgets are closed #1181
Process widget data in background when widgets are closed #1181
Conversation
Tested and confirmed the changes are working as expected 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend checking the debug flag before entering the debug method, rather than after. The function name should be something of a contract to the developer. If it says it will do something, it should do it. In this case, the function name is debugTimeSeriesDataSamplingRate
but in truth it's more like debugTimeSeriesDataSamplingRateIfDebugFlagIsSet
as implemented. That could be confusing to a future developer who calls that function, but doesn't set the flag. Setting the flag outside the function avoids that confusion.
Everything else looks good - no need to re-request a review after fixing the above. I'll approve now and you can go ahead and merge after.
…widget is closed Also, process Digital Read in the background
…eserving sampling rate
…code review comments
Refactor usage of debugTimeSeriesDataSamplingRate
af9cd8b
to
4abc3a4
Compare
Closes #1094 |
Networking Outputs, and those that need data processed in the background: