Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process widget data in background when widgets are closed #1181

Merged
merged 12 commits into from
Sep 11, 2023

Conversation

retiutut
Copy link
Member

@retiutut retiutut commented Aug 28, 2023

Networking Outputs, and those that need data processed in the background:

  • Time Series filtered - Done
  • Time Series unfiltered - Done
  • Focus - NEED
  • FFT - Done
  • EMG - Done
  • AvgBandPower - NEED
  • BandPower - Done
  • Accelerometer - NEED
  • Digital Read - NEED
  • Analog Read - NEED
  • Pulse - NEED
  • EMG Joystick - NEED
  • Marker - Done
  • Process sampling rate dependent data accumulation in background when Networking widget is closed

@retiutut retiutut requested a review from philippitts August 30, 2023 00:14
@retiutut retiutut marked this pull request as ready for review August 30, 2023 00:14
@philippitts
Copy link
Member

Tested and confirmed the changes are working as expected 👍

Copy link
Member

@philippitts philippitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend checking the debug flag before entering the debug method, rather than after. The function name should be something of a contract to the developer. If it says it will do something, it should do it. In this case, the function name is debugTimeSeriesDataSamplingRate but in truth it's more like debugTimeSeriesDataSamplingRateIfDebugFlagIsSet as implemented. That could be confusing to a future developer who calls that function, but doesn't set the flag. Setting the flag outside the function avoids that confusion.

Everything else looks good - no need to re-request a review after fixing the above. I'll approve now and you can go ahead and merge after.

@retiutut retiutut force-pushed the process-widget-data-background-networking branch from af9cd8b to 4abc3a4 Compare September 11, 2023 20:49
@retiutut retiutut merged commit 0afebcf into development Sep 11, 2023
@retiutut retiutut deleted the process-widget-data-background-networking branch September 11, 2023 20:53
@retiutut
Copy link
Member Author

Closes #1094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants