Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow Arbitrary Credentials From user_settings.json To Populate Credentials Model #7040

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Items defined in user_settings["credentials"] only populate if they are in the ProviderInterface, this is not ideal.
  2. What?:

    • Populates the Credentials model with any leftover key:value pairs from user_settings.json, if it exists.
  3. Impact:

    • Improved developer experience, more freedom.
    • Arbitrary keys being defined have no real consequence, but greatly improve the flexibility - like incorporating Hub configurations with completely custom APIs and apps that are authorized by a remote script.
  4. Testing Done:

Screenshot 2025-02-21 at 9 42 57 PM

@deeleeramone deeleeramone added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Feb 22, 2025
@deeleeramone deeleeramone requested a review from piiq February 22, 2025 05:45
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that we already support this, but then i realized that all my custom keys are the keys to custom providers that are defined as providers

@piiq piiq added this pull request to the merge queue Feb 22, 2025
Merged via the queue into develop with commit ca3a338 Feb 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants