Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] Fix obbject extensions not written to extension_map.json #6195

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

the-praxs
Copy link
Contributor

@the-praxs the-praxs commented Mar 12, 2024

[HotFix] Fix obbject extensions not written to extension_map.json

  1. Why?

    To properly write the obbject extensions in extension_map.json

  2. What?

    • Adds property in ExtensionLoader and OpenBBGroups classes to access the entry points and groups respectively
    • Fixes the code in PackageBuilder class to properly write the obbject extensions in extension_map.json
  3. Impact

    Severe impact since its a critical bug

  4. Testing Done:

    Tested locally by building the static and validating the extension_map.json

  5. Additional Notes:

    An additional PR will be created to release the updated openbb-core package

@the-praxs the-praxs requested a review from montezdesousa March 12, 2024 17:39
@github-actions github-actions bot added bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4 labels Mar 12, 2024
@the-praxs the-praxs merged commit d2fb4e1 into main Mar 12, 2024
10 checks passed
@the-praxs the-praxs deleted the hotfix/obbject-extension branch March 12, 2024 19:08
@montezdesousa montezdesousa restored the hotfix/obbject-extension branch March 12, 2024 19:18
@piiq piiq deleted the hotfix/obbject-extension branch March 13, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants