Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] 4.1.5 to develop #6192

Merged
merged 20 commits into from
Mar 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
no linting for terminal v3
the-praxs committed Mar 12, 2024

Verified

This commit was signed with the committer’s verified signature.
the-praxs Pratyush Shukla
commit e6fdd7031dbb0aac0295cb9ca20d92991b1cf6cc
17 changes: 8 additions & 9 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
@@ -67,15 +67,14 @@ jobs:
- run: black --diff --check .
- run: codespell --ignore-words=.codespell.ignore --skip="$(tr '\n' ',' < .codespell.skip | sed 's/,$//')" --quiet-level=2
- run: ruff .
- run: |
# Run linters for openbb_terminal
if [ -n "${{ env.terminal_files }}" ]; then
# TODO: Add mypy to this part of the linting workflow once we're ready
# mypy --ignore-missing-imports ${{ env.terminal_files }}
pylint terminal.py ${{ env.terminal_files }}
else
echo "No Python files changed in openbb_terminal"
fi
# - run: |
# # Run linters for openbb_terminal
# if [ -n "${{ env.terminal_files }}" ]; then
# mypy --ignore-missing-imports ${{ env.terminal_files }}
# pylint terminal.py ${{ env.terminal_files }}
# else
# echo "No Python files changed in openbb_terminal"
# fi
- run: |
# Run linters for openbb_platform
if [ -n "${{ env.platform_files }}" ]; then