-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - refactor examples #6154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Enhancement
platform
OpenBB Platform
v4
PRs for v4
labels
Mar 1, 2024
IgorWounds
approved these changes
Mar 9, 2024
openbb_platform/extensions/economy/openbb_economy/economy_router.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
to_df
, other times accessing internal obbject attributes, etc. This will only get worse with time if we don't impose any restrictions on how the example should lookWhat?
APIEx
andPythonEx
to_python
method that renders the example into python code (pacakge_builder.py then calls this to create docstrings)APIEx
are more structured aiming to be language agnostic - provide less freedomPythonEx
give more freedom to create complex examplesopenapi.json
and python docstringsImpact:
generate_platform_markdown.py
needs a few tweaks to get the examples @the-praxsgenerate_excel_markdown.py
will start using these examples when this reaches productionTesting Done: