-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the OECD requests #6152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The start/end date thing needs to be applied to the GDP functions as well. You could also add an "all" to these.
Generally, it's downloading much better now. I made sure to delete all the existing cache.
The test cassettes need to be recaptured and the types in the Fetcher need to be a List[Dict]
instead of Dict
.
openbb_platform/providers/oecd/openbb_oecd/models/composite_leading_indicator.py
Outdated
Show resolved
Hide resolved
The GDP functions actually need to be updated from the old stats.oecd endpoints to the newer sdmx. That is out of the scope here (those also don't touch cache) -- but is 100% on the roadmap. The start/end are simple enough |
2039eb9
to
3252bfe
Compare
openbb_platform/providers/oecd/openbb_oecd/models/gdp_forecast.py
Outdated
Show resolved
Hide resolved
] | ||
data_df["date"] = data_df["date"].apply( | ||
lambda x: x.year | ||
) # Validator won't accept datetime.date? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is because the validator is expecting a string representation. Although, because you have already conformed the date field in the extract process, the validator is now redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that too but it accepts str|date so it was unclear what was actually going wrong
Pull Request Template for OpenBB Developers
Title:
Why? (1-3 sentences or a bullet point list):
What? (1-3 sentences or a bullet point list):
Change the URL to get specific fields instead of all data
Change the cache to have a key that depends on the input query params.
Impact (1-2 sentences or a bullet point list):
Testing Done:
Funcs done: