Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Removal] Remove Ultima provider #6012

Merged
merged 2 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions openbb_platform/PROVIDERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@

| Provider | URL | Package name | Description | Maintainer |
| --- | --- | --- | --- | --- |
| [FMP](./providers/fmp/README.md) | https://financialmodelingprep.com/ | `openbb-fmp` | Access all stocks discounted cash flow statements, market price, stock markets news, and learn more about Financial Modeling. | [@OpenBB-Finance](https://github.com/OpenBB-finance) |
| [Polygon](./providers/polygon/README.md) | https://polygon.io/ | `openbb-polygon` | Free stock data APIs. Real time and historical data, unlimited usage, tick level and aggregate granularity, in standardized JSON and CSV formats. | [@OpenBB-Finance](https://github.com/OpenBB-finance) |
| [Benzinga](./providers/benzinga/README.md) | https://www.benzinga.com/ | `openbb-benzinga` | Stock Market Quotes, Business News, Financial News, Trading Ideas, and Stock Research by Professionals. | [@OpenBB-Finance](https://github.com/OpenBB-finance) |
| [FRED](./providers/fred/README.md) | https://fred.stlouisfed.org/ | `openbb-fred` | Download, graph, and track 823000 economic time series from 114 sources. | [@OpenBB-Finance](https://github.com/OpenBB-finance) |
| [Ultima](./providers/ultima/README.md) | https://ultimainsights.ai | `openbb-ultima` | Ultima Insights harnesses the power of LLMs + GPT to present relevant news to investors, often before it appears on platforms like Bloomberg. Ultima aims to provide timely and significant information for its users. | [@Ultima-Insights](https://github.com/Ultima-Insights)
| [FMP](./providers/fmp/README.md) | <https://financialmodelingprep.com/> | `openbb-fmp` | Access all stocks discounted cash flow statements, market price, stock markets news, and learn more about Financial Modeling. | [@OpenBB-Finance](https://github.com/OpenBB-finance) |
| [Polygon](./providers/polygon/README.md) | <https://polygon.io/> | `openbb-polygon` | Free stock data APIs. Real time and historical data, unlimited usage, tick level and aggregate granularity, in standardized JSON and CSV formats. | [@OpenBB-Finance](https://github.com/OpenBB-finance) |
| [Benzinga](./providers/benzinga/README.md) | <https://www.benzinga.com/> | `openbb-benzinga` | Stock Market Quotes, Business News, Financial News, Trading Ideas, and Stock Research by Professionals. | [@OpenBB-Finance](https://github.com/OpenBB-finance) |
| [FRED](./providers/fred/README.md) | <https://fred.stlouisfed.org/> | `openbb-fred` | Download, graph, and track 823000 economic time series from 114 sources. | [@OpenBB-Finance](https://github.com/OpenBB-finance) |

<!-- Add your Data Provider integration above this line -->
9 changes: 4 additions & 5 deletions openbb_platform/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ This will install the following data providers:
| openbb-sec | [SEC](https://www.sec.gov/edgar/sec-api-documentation) data connector | pip install openbb-sec | Free |
| openbb-tiingo | [Tiingo](https://www.tiingo.com/about/pricing) data connector | pip install openbb-tiingo | Free |
| openbb-tradingeconomics | [TradingEconomics](https://tradingeconomics.com/api) data connector | pip install openbb-tradingeconomics | Paid |
| openbb-ultima | [Ultima Insights](https://ultimainsights.ai/openbb) data connector | pip install openbb-ultima | Paid |


To install extensions that expand the core functionalities specify the extension name or use `all` to install all.

Expand All @@ -48,9 +46,10 @@ pip install openbb[charting]
pip install openbb-yfinance
```

Alternatively, you can install all extensions at once.
Alternatively, you can install all extensions at once.

```bash
pip install openbb[all]
pip install openbb[all]
```

> Note: These instruction are specific to v4. For installation instructions and documentation for v3 go to our [website](https://docs.openbb.co/sdk).
Expand Down Expand Up @@ -83,7 +82,7 @@ To fully leverage the OpenBB Platform you need to get some API keys to connect w

### 1. OpenBB Hub

Set your keys at [OpenBB Hub](https://my.openbb.co/app/sdk/api-keys) and get your personal access token from https://my.openbb.co/app/sdk/pat to connect with your account.
Set your keys at [OpenBB Hub](https://my.openbb.co/app/sdk/api-keys) and get your personal access token from <https://my.openbb.co/app/sdk/pat> to connect with your account.

```python
>>> from openbb import obb
Expand Down
2 changes: 0 additions & 2 deletions openbb_platform/core/openbb_core/app/service/hub_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ def hub2platform(cls, settings: HubUserSettings) -> Credentials:
intrinio_api_key=settings.features_keys.API_INTRINIO_KEY,
polygon_api_key=settings.features_keys.API_POLYGON_KEY,
nasdaq_api_key=settings.features_keys.API_KEY_QUANDL,
ultima_api_key=settings.features_keys.API_ULTIMA_KEY,
)
return credentials

Expand All @@ -249,7 +248,6 @@ def get_cred(cred: str) -> Optional[str]:
API_KEY_FINANCIALMODELINGPREP=get_cred("fmp_api_key"),
API_POLYGON_KEY=get_cred("polygon_api_key"),
API_KEY_QUANDL=get_cred("nasdaq_api_key"),
API_ULTIMA_KEY=get_cred("ultima_api_key"),
)
hub_user_settings = HubUserSettings(features_keys=features_keys)
return hub_user_settings
Expand Down
29 changes: 0 additions & 29 deletions openbb_platform/extensions/news/integration/test_news_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,6 @@ def test_news_world(params, headers):
"source": "bloomberg.com",
}
),
# (
# {
# "provider": "ultima",
# "sectors": "Real Estate",
# }
# ),
],
)
@pytest.mark.integration
Expand All @@ -164,26 +158,3 @@ def test_news_company(params, headers):
result = requests.get(url, headers=headers, timeout=10)
assert isinstance(result, requests.Response)
assert result.status_code == 200


@pytest.mark.skip("openbb-ultima is not installed on the CI.")
@parametrize(
"params",
[
(
{
"provider": "ultima",
"sectors": "Real Estate",
}
),
],
)
@pytest.mark.integration
def test_news_sector(params, headers):
params = {p: v for p, v in params.items() if v}

query_str = get_querystring(params, [])
url = f"http://0.0.0.0:8000/api/v1/news/sector?{query_str}"
result = requests.get(url, headers=headers, timeout=10)
assert isinstance(result, requests.Response)
assert result.status_code == 200
28 changes: 0 additions & 28 deletions openbb_platform/extensions/news/integration/test_news_python.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,6 @@ def test_news_world(params, obb):
"source": "bloomberg.com",
}
),
# (
# {
# "provider": "ultima",
# "symbols": "AAPL,MSFT",
# }
# ),
],
)
@pytest.mark.integration
Expand All @@ -157,25 +151,3 @@ def test_news_company(params, obb):
assert result
assert isinstance(result, OBBject)
assert len(result.results) > 0


@pytest.mark.skip("openbb-ultima is not installed on the CI.")
@parametrize(
"params",
[
(
{
"provider": "ultima",
"sectors": "Real Estate",
}
),
],
)
@pytest.mark.integration
def test_news_sector(params, obb):
params = {p: v for p, v in params.items() if v}

result = obb.news.sector(**params)
assert result
assert isinstance(result, OBBject)
assert len(result.results) > 0
15 changes: 0 additions & 15 deletions openbb_platform/providers/ultima/README.md

This file was deleted.

Empty file.
27 changes: 0 additions & 27 deletions openbb_platform/providers/ultima/openbb_ultima/__init__.py

This file was deleted.

Empty file.

This file was deleted.

103 changes: 0 additions & 103 deletions openbb_platform/providers/ultima/openbb_ultima/models/sector_news.py

This file was deleted.

Empty file.
Empty file.
Loading
Loading