Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/charting obbject #5938

Merged
merged 110 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from 98 commits
Commits
Show all changes
110 commits
Select commit Hold shift + click to select a range
7252353
fix circular import issues on the obbject extension framework
hjoaquim Jan 9, 2024
b73f2ab
settings available on the obbject
hjoaquim Jan 9, 2024
79a5e75
extension init
hjoaquim Jan 9, 2024
ff7b448
charting assets and code
hjoaquim Jan 9, 2024
7b6b432
introduce to_chart functionality
hjoaquim Jan 10, 2024
32c5c8d
removes the to_chart method from obbject in detriment of the one from…
hjoaquim Jan 10, 2024
cd08218
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 10, 2024
e846056
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 10, 2024
6643d24
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 10, 2024
c6353ad
Update openbb_platform/obbject_extensions/charting/charting/__init__.py
hjoaquim Jan 13, 2024
5333162
Merge branch 'develop' into feature/charting-obbject
deeleeramone Jan 14, 2024
252ec2b
fix on the show method
hjoaquim Jan 16, 2024
59ebe87
adding the example to the to_chart docstring
hjoaquim Jan 16, 2024
da35744
copying the exsting README from charting extension - needs to be reva…
hjoaquim Jan 16, 2024
18121cf
moving to openbb_charting instead
hjoaquim Jan 16, 2024
5f91e61
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 16, 2024
b518898
update the pyproject.toml file
hjoaquim Jan 16, 2024
d00c22f
Merge branch 'feature/charting-obbject' of github.com:OpenBB-finance/…
hjoaquim Jan 16, 2024
31308ff
Merge branch 'develop' into feature/charting-obbject
IgorWounds Jan 18, 2024
55a0b70
Merge branch 'develop' into feature/charting-obbject
IgorWounds Jan 22, 2024
0ba0552
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 24, 2024
0ce80fa
pydocstyle
hjoaquim Jan 24, 2024
d742e28
versions
hjoaquim Jan 24, 2024
b5bd1b8
better docstrings
hjoaquim Jan 24, 2024
c3a6d76
making accessors public
hjoaquim Jan 24, 2024
8ec4d64
removing unnecessary credentials variable cc @montezdesousa
hjoaquim Jan 24, 2024
5a62a09
removing access to extra/metadata and use designated private attrs in…
hjoaquim Jan 24, 2024
e2f3dd0
Fixes linting for the logging service (#5992)
hjoaquim Jan 24, 2024
f78ac80
deprecating ChartingService to use the new extension instead - adding…
hjoaquim Jan 24, 2024
7ccecc3
Merge branch 'feature/charting-obbject' of github.com:OpenBB-finance/…
hjoaquim Jan 24, 2024
5e9a7cc
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 24, 2024
f11653c
tests for the obbject charting extension
hjoaquim Jan 24, 2024
437dd71
removing charting service from command runner
hjoaquim Jan 24, 2024
a04a55c
Merge branch 'feature/charting-obbject' of github.com:OpenBB-finance/…
hjoaquim Jan 24, 2024
1f0b063
filter functions not implemented in the module
hjoaquim Jan 25, 2024
948d2ef
remove charting service tests
hjoaquim Jan 25, 2024
04b3a12
removing charting service on the tests for int tests
hjoaquim Jan 25, 2024
83d34e3
charting integration tests
hjoaquim Jan 25, 2024
10eb798
removing charting service file
hjoaquim Jan 25, 2024
1b568e7
removing old charting extension code
hjoaquim Jan 25, 2024
0e001a3
revamp builder
hjoaquim Jan 25, 2024
1a00fb2
fix obbject tests
hjoaquim Jan 25, 2024
387252a
fix command_runner tests
hjoaquim Jan 25, 2024
45a1edf
removing openbb_figure_table
hjoaquim Jan 25, 2024
b29148d
better website docs
hjoaquim Jan 25, 2024
0350eb7
reviewed readme
hjoaquim Jan 25, 2024
cfa4b00
unsetting api key for posthog (pywry) windows
hjoaquim Jan 25, 2024
711020c
added debug_mode to the system settings
hjoaquim Jan 25, 2024
018c93c
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 25, 2024
e99e71f
removing api key
hjoaquim Jan 25, 2024
738898c
Merge branch 'feature/charting-obbject' of github.com:OpenBB-finance/…
hjoaquim Jan 25, 2024
1895dd7
update nightly script
hjoaquim Jan 25, 2024
a288422
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 25, 2024
48de17d
fix tests
hjoaquim Jan 25, 2024
1d872c1
Merge branch 'feature/charting-obbject' of github.com:OpenBB-finance/…
hjoaquim Jan 25, 2024
1486ed0
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 25, 2024
445d91a
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 26, 2024
d66dea2
Merge remote-tracking branch 'OpenBB-finance/develop' into feature/ch…
hjoaquim Jan 26, 2024
8d3ad24
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 29, 2024
1a7cac5
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 29, 2024
1f2886c
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 29, 2024
772ae95
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 29, 2024
21d76ad
black
hjoaquim Jan 29, 2024
0904653
black
hjoaquim Jan 29, 2024
321e01f
Revert "black"
hjoaquim Jan 29, 2024
e28b794
Revert "black"
hjoaquim Jan 29, 2024
522efd3
black for henrique
jmaslek Jan 29, 2024
35bfb70
Merge branch 'feature/charting-obbject' of https://github.com/OpenBB-…
jmaslek Jan 29, 2024
f74f941
returning a list instead
hjoaquim Jan 29, 2024
a4cb2da
better docstrings
hjoaquim Jan 29, 2024
a1e3379
removing unnecessary indicators docstring
hjoaquim Jan 29, 2024
c09f978
typo
hjoaquim Jan 29, 2024
30eb593
black
hjoaquim Jan 29, 2024
bdac9f6
intentional access to protected member
hjoaquim Jan 29, 2024
4669a30
changes to publish script
hjoaquim Jan 29, 2024
c424bf5
filtering deleted files
hjoaquim Jan 29, 2024
83e6e86
black
hjoaquim Jan 29, 2024
19191dc
Merge branch 'develop' into feature/charting-obbject
hjoaquim Jan 30, 2024
356f966
adding render argument
hjoaquim Jan 31, 2024
f39a469
fixing the df_to_basemodel function: it should include the index in t…
hjoaquim Feb 1, 2024
30167b0
adding the hability to add you own data to to_chart method
hjoaquim Feb 1, 2024
fba1f2c
tests
hjoaquim Feb 1, 2024
120a731
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 1, 2024
e4a52ce
black
hjoaquim Feb 1, 2024
b2ae747
disable protected access
hjoaquim Feb 1, 2024
b8bf601
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 1, 2024
bb28a40
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 2, 2024
e07c0c1
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 2, 2024
062b142
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 3, 2024
9dce8f2
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 5, 2024
75f3164
accept kwargs to eg. save image
hjoaquim Feb 5, 2024
35a10aa
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 5, 2024
b903d54
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 6, 2024
0bc3a3d
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 7, 2024
8ea5983
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 7, 2024
1bb8c4b
Merge branch 'develop' into feature/charting-obbject
IgorWounds Feb 8, 2024
58020fa
Merge branch 'develop' into feature/charting-obbject
deeleeramone Feb 8, 2024
a015c8f
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 13, 2024
9f27521
adjustment cc Igor
hjoaquim Feb 13, 2024
2d598ac
add if statement for protection
hjoaquim Feb 13, 2024
672766c
remove unused return typing
hjoaquim Feb 13, 2024
ee3c0f8
fix technical charting views
hjoaquim Feb 13, 2024
184dfd3
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 13, 2024
3d7ee53
better error message cc @IgorWounds
hjoaquim Feb 14, 2024
972e80c
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 14, 2024
612ea61
better structure and fix test
hjoaquim Feb 14, 2024
be8f363
Merge branch 'feature/charting-obbject' of github.com:OpenBB-finance/…
hjoaquim Feb 14, 2024
7cb115f
Merge branch 'develop' into feature/charting-obbject
hjoaquim Feb 14, 2024
dd0935f
Revert "better structure and fix test"
hjoaquim Feb 14, 2024
b876d31
Revert "better error message cc @IgorWounds"
hjoaquim Feb 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
# "Checking PR diff"
echo "terminal_files=$(git diff --name-only origin/${{ github.base_ref }}...${{ github.head_ref }} | grep 'openbb_terminal/.*\.py$' | xargs)" >> $GITHUB_ENV
echo $terminal_files
echo "platform_files=$(git diff --name-only origin/${{ github.base_ref }}...${{ github.head_ref }} | grep 'openbb_platform/.*\.py$' | grep -v 'openbb_platform/openbb/package' | grep -v 'integration' | grep -v 'tests' | xargs)" >> $GITHUB_ENV
echo "platform_files=$(git diff --diff-filter=d --name-only origin/${{ github.base_ref }}...${{ github.head_ref }} | grep 'openbb_platform/.*\.py$' | grep -v 'openbb_platform/openbb/package' | grep -v 'integration' | grep -v 'tests' | xargs)" >> $GITHUB_ENV
echo $platform_files

- uses: actions/cache@v3
Expand Down
3 changes: 2 additions & 1 deletion build/pypi/openbb_platform/nightly.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
PLUGINS: Dict[str, Dict] = {
"openbb_core_extension": {},
"openbb_provider_extension": {},
"openbb_obbject_extension": {},
}
CMD = [sys.executable, "-m", "poetry", "build"]

Expand Down Expand Up @@ -47,7 +48,7 @@ def gather_metadata(sub_path: str):

def build():
"""Build the Platform package."""
for sub_path in ["core", "providers", "extensions"]:
for sub_path in ["core", "providers", "extensions", "obbject_extensions"]:
gather_metadata(sub_path)

# need to pop these from the dependencies
Expand Down
2 changes: 1 addition & 1 deletion build/pypi/openbb_platform/publish.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
PLATFORM_PATH = Path(__file__).parent.parent.parent.parent.resolve() / "openbb_platform"

CORE_PACKAGES = ["core"]
EXTENSION_PACKAGES = ["extensions", "providers"]
EXTENSION_PACKAGES = ["extensions", "providers", "obbject_extensions"]

CMD = [sys.executable, "-m", "poetry"]
EXTENSION_DEPENDENCIES_UPDATE_CMD = ["add", "openbb-core=latest", "--lock"]
Expand Down
16 changes: 11 additions & 5 deletions openbb_platform/core/openbb_core/api/router/commands.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
"""Commands: generates the command map."""

import inspect
from functools import partial, wraps
from inspect import Parameter, Signature, signature
from typing import Any, Callable, Dict, Optional, Tuple, TypeVar

from fastapi import APIRouter, Depends, Header
from fastapi.routing import APIRoute
from openbb_core.app.charting_service import ChartingService
from openbb_core.app.command_runner import CommandRunner
from openbb_core.app.model.command_context import CommandContext
from openbb_core.app.model.obbject import OBBject
Expand All @@ -18,6 +19,13 @@
from pydantic import BaseModel
from typing_extensions import Annotated, ParamSpec

try:
from openbb_charting import Charting

CHARTING_INSTALLED = True
except ImportError:
CHARTING_INSTALLED = False

T = TypeVar("T")
P = ParamSpec("P")

Expand Down Expand Up @@ -57,10 +65,7 @@ def build_new_signature(path: str, func: Callable) -> Signature:
)
)

if (
path.replace("/", "_")[1:]
in ChartingService.get_implemented_charting_functions()
):
if CHARTING_INSTALLED and path.replace("/", "_")[1:] in Charting.functions():
new_parameter_list.append(
Parameter(
"chart",
Expand Down Expand Up @@ -104,6 +109,7 @@ def build_new_signature(path: str, func: Callable) -> Signature:
def validate_output(c_out: OBBject) -> OBBject:
"""
Validate OBBject object.

Checks against the OBBject schema and removes fields that contain the
`exclude_from_api` extra `pydantic.Field` kwarg.
Note that the modification to the `OBBject` object is done in-place.
Expand Down
287 changes: 0 additions & 287 deletions openbb_platform/core/openbb_core/app/charting_service.py

This file was deleted.

Loading
Loading