-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker and docker-compose support #13
Conversation
I'm getting an error on build. I wonder if you're seeing this too? 🙂 I'll investigate on my side.
|
Looking |
Pull and retry. It is building the container now, but breaking when running with error |
@DidierRLopes I just merged the "main" branch into this branch and now getting:
when trying to build the Docker container. |
Related: I added the ability to build the container with GitHub Actions. |
I've updated the requirements based on a PR, where it imports all dependencies needed. Since I've received several messages complaining about the requirements.txt. However, in my machine, I can confirm that the scipy I have installed is 1.4.1. Can you try to build it with scipy==1.4.1. please? I've tried to build the docker container myself and I'm getting the following error:
|
@DidierRLopes changing to version Looks like that PR that added
Pull my branch and retry |
Thank you, this is much appreciated! Let me give it a go. |
Ok, we getting closer with my latest commit. I think
|
The docker is still failing on my end, but at the build. I'm not familiar with docker images. so I need to try to understand what's going on better, and then make sure everything still works smoothly. I'm starting work soon, and will be again available at the end of the day to continue having a look at this. Again, I appreciate a lot your help with this! Thanks. |
I got it running in Docker, by removing the I also updated pip, setuptools and wheel, and ran the entire dependencies in a virtual environment:
And it runs. |
@micheloosterhof why create and use a venv if this is in Docker? What’s the benefit? I will try removing appscript and bumping scipy to version 1.5.4. |
Just a heads up, scipy 1.6.1 requires Python >= 3.7. I was looking at Dockerizing before I saw this PR, let me know if there's any help I can provide! |
More control over your Python environment, no interference with the system provided Python libraries. |
Hmm, I ended up having to go with
But I was using ubuntu as a base as I am a noob |
@nodesocket Thanks for your work getting docker up and running. We had to made some tiny changes because we are moving the project to poetry. You can see the changes here If you change your PR so that collaborators can edit your branch, we can merge our changes here in this PR. The only concern I have is around charts. The charts in GamestonkTerminal require a display so that matplot lib can draw. With docker that doesn't happen. The commands seem to work fine but the charts aren't shown. It is possible to attach a display to a docker container see but it seems really complicated for most users and kinda against the point of leveraging docker in the first place. With the change to poetry we are working hard on making GamestonkTerminal installable on multiple versions of python. I think in the future we could change the code so that it either doesn't draw charts if no display is detected or maybe draws ASCII charts or something? Then docker becomes a much more viable option. Really interested in your thoughts on this and really appreciate the effort you put into this PR. 🚀 🚀 GamestonkTerminal to the 🌔 |
@shadycuz how do I allow collaborators to edit this branch? Sorry, not seeing that option. |
@shadycuz I think it is already enabled? |
Hey @nodesocket @amingilani @auxon @micheloosterhof , Thank you for this! Me and @shadycuz added on top of this (https://github.com/DidierRLopes/GamestonkTerminal/pull/76) and have now pushed the changes to the main branch. Let me know if you have any issue. |
Last rich controllers updated
Docker and
docker-compose
support.To build:
To get a bash terminal:
To run the app:
Currently breaking 😿 🔨 with: