improved market cap value extraction (#5169)

* improved market cap value extraction * pylint --------- Co-authored-by: James Maslek <[email protected]>
OpenBB-finance · Nov 8, 2023 · acf8b06 · acf8b06
1 parent cfc40e7
commit acf8b06
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/openbb_terminal/portfolio/portfolio_optimization/optimizer_model.py b/openbb_terminal/portfolio/portfolio_optimization/optimizer_model.py
@@ -343,18 +343,19 @@ def get_market_cap(symbol) -> float:
         latest_year = market_cap.index[-1]
 
         value = market_cap.loc[latest_year]["Market capitalization"]
-
-        if "M" in value:
-            updated_value = float(value.split(" M")[0]) * 1000000
-        elif "B" in value:
-            updated_value = float(value.split(" B")[0]) * 1000000000
-        elif "T" in value:
-            updated_value = float(value.split(" T")[0]) * 1000000000000
+        values_str = str(value)
+
+        # use values_str in string operations
+        if values_str.endswith("M"):
+            updated_value = float(values_str.split(" M", maxsplit=1)[0]) * 1000000
+        elif values_str.endswith("B"):
+            updated_value = float(values_str.split(" B", maxsplit=1)[0]) * 1000000000
+        elif values_str.endswith("T"):
+            updated_value = float(values_str.split(" T", maxsplit=1)[0]) * 1000000000000
         else:
-            updated_value = float(value)
+            updated_value = float(values_str)
     else:
         updated_value = 0
-
     return updated_value