-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Refactored TagRule to use AssetGRoup instead of Assets Issue/1998 #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.0 #2170 +/- ##
====================================================
+ Coverage 32.49% 32.64% +0.14%
- Complexity 1509 1514 +5
====================================================
Files 580 581 +1
Lines 18056 18063 +7
Branches 1158 1158
====================================================
+ Hits 5867 5896 +29
+ Misses 11925 11903 -22
Partials 264 264 ☔ View full report in Codecov by Sentry. |
savacano28
reviewed
Jan 9, 2025
openbas-api/src/main/java/io/openbas/rest/inject/service/InjectService.java
Show resolved
Hide resolved
savacano28
reviewed
Jan 9, 2025
openbas-api/src/main/java/io/openbas/migration/V3_57__TagRule_Update.java
Outdated
Show resolved
Hide resolved
savacano28
reviewed
Jan 9, 2025
openbas-api/src/main/java/io/openbas/rest/inject/service/InjectService.java
Outdated
Show resolved
Hide resolved
savacano28
approved these changes
Jan 9, 2025
heditar
changed the title
[backend] Refactore TagRule to use AssetGRoup instead of Assets Issue/1998
[backend] Refactored TagRule to use AssetGRoup instead of Assets Issue/1998
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist