Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Refactored TagRule to use AssetGRoup instead of Assets Issue/1998 #2170

Merged
merged 12 commits into from
Jan 9, 2025

Conversation

heditar
Copy link
Contributor

@heditar heditar commented Jan 8, 2025

Proposed changes

  • Refactored the code so the TagRule use AssetGroup instead of Assets

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.64%. Comparing base (173467c) to head (84b3de8).
Report is 3 commits behind head on release/1.11.0.

Files with missing lines Patch % Lines
...c/main/java/io/openbas/service/TagRuleService.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.11.0    #2170      +/-   ##
====================================================
+ Coverage             32.49%   32.64%   +0.14%     
- Complexity             1509     1514       +5     
====================================================
  Files                   580      581       +1     
  Lines                 18056    18063       +7     
  Branches               1158     1158              
====================================================
+ Hits                   5867     5896      +29     
+ Misses                11925    11903      -22     
  Partials                264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heditar heditar changed the title [backend] Refactore TagRule to use AssetGRoup instead of Assets Issue/1998 [backend] Refactored TagRule to use AssetGRoup instead of Assets Issue/1998 Jan 9, 2025
@heditar heditar merged commit 21d1822 into release/1.11.0 Jan 9, 2025
4 checks passed
@heditar heditar deleted the issue/1998 branch January 9, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants