Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix: fixed adding empty filters on datatables #2142

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

impolitepanda
Copy link
Member

Proposed changes

  • Fix or a bug when adding an empty filter in a datatable

Related issues

  • No issue created

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

To reproduce the bug before this fix, follow these steps:

  • Go to any datatable where filters can be added (example: list of injects for a given scenario)
  • Add a new filter (example: type)
  • click outside the box, without setting any value

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.10%. Comparing base (fec6ba7) to head (cd857c1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2142   +/-   ##
=========================================
  Coverage     35.10%   35.10%           
  Complexity     1418     1418           
=========================================
  Files           535      535           
  Lines         16198    16198           
  Branches       1037     1037           
=========================================
  Hits           5686     5686           
  Misses        10218    10218           
  Partials        294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@impolitepanda impolitepanda merged commit 5da98fb into master Jan 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants