Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] When I select injects and export them, the entire list is exported #2113

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

isselparra
Copy link
Contributor

Proposed changes

  • [frontend] allow only selected injects to be exported

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@isselparra isselparra self-assigned this Dec 19, 2024
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Dec 19, 2024
@savacano28 savacano28 self-requested a review December 19, 2024 11:23
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.11%. Comparing base (fb0fab9) to head (e99ee17).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2113   +/-   ##
=========================================
  Coverage     35.11%   35.11%           
  Complexity     1418     1418           
=========================================
  Files           535      535           
  Lines         16187    16187           
  Branches       1037     1037           
=========================================
  Hits           5684     5684           
  Misses        10209    10209           
  Partials        294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra merged commit c660d4d into master Dec 19, 2024
7 checks passed
@isselparra isselparra deleted the issue/2111 branch December 19, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I select injects and export them, the entire list is exported
3 participants