Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] PoC Frontend Error Log Collector Implementation (#1964) #1959

Open
wants to merge 17 commits into
base: release/current
Choose a base branch
from

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Nov 29, 2024

Proposed changes

  • Add endpoint to log errors from Frontend on backend side:

Screenshot 2025-01-10 160552
image

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 changed the title Issue/collector frontend errors [backend/frontend] PoC Frontend Error Log Collector Implementation Nov 29, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 32.88%. Comparing base (b79242c) to head (ebb9601).

Files with missing lines Patch % Lines
...-api/src/main/java/io/openbas/rest/log/LogApi.java 10.52% 17 Missing ⚠️
...java/io/openbas/rest/log/form/LogDetailsInput.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #1959      +/-   ##
=====================================================
- Coverage              32.90%   32.88%   -0.03%     
- Complexity              1512     1514       +2     
=====================================================
  Files                    582      584       +2     
  Lines                  17937    17957      +20     
  Branches                1154     1154              
=====================================================
+ Hits                    5903     5905       +2     
- Misses                 11770    11788      +18     
  Partials                 264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the issue/collector-frontend-errors branch from a8d8aef to 97890e9 Compare November 29, 2024 17:41
@savacano28 savacano28 changed the title [backend/frontend] PoC Frontend Error Log Collector Implementation [backend/frontend] PoC Frontend Error Log Collector Implementation (#1964) Dec 3, 2024
@savacano28 savacano28 force-pushed the issue/collector-frontend-errors branch from 59d1979 to 8cc6f42 Compare December 20, 2024 14:37
@savacano28 savacano28 force-pushed the issue/collector-frontend-errors branch from 9affa26 to 4c88e04 Compare January 10, 2025 14:17
@savacano28 savacano28 marked this pull request as ready for review January 10, 2025 15:00
@savacano28 savacano28 force-pushed the issue/collector-frontend-errors branch from 33e14a9 to ebb9601 Compare January 17, 2025 08:23
@savacano28 savacano28 changed the base branch from master to release/current January 17, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend Error Logging
2 participants