feat: hash command hrandfield #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mac环境ci失败了，帮忙测一下 |
Centurybbx
reviewed
Jan 7, 2024
Centurybbx
reviewed
Jan 9, 2024
|
whether to consider using blackwidow interface |
这个bw接口没支持，pika不支持这个命令，常远自己实现的bw接口 |
longfar-ncy
commented
Jan 11, 2024
| save_idx++; | ||
| } | ||
| if (!iter->Valid()) { | ||
| return Status::IOError(fmt::format("Should search for the data starting with {}", prefix.ToString())); |
There was a problem hiding this comment.
这里理应找到对应的kv，iterator应该是valid的。如果不是，我这里设为了IOError，如果有其他更好的选择，请提出建议
longfar-ncy
force-pushed
the
feat/hrandfield
branch
from
ba57ee1 to
6b97e01
Compare
longfar-ncy
force-pushed
the
feat/hrandfield
branch
from
6b97e01 to
2b55a03
Compare
|
@longfar-ncy 解决一下冲突 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #30