-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Supports coexistence of multiple protobuf versions #388
fix: Supports coexistence of multiple protobuf versions #388
Conversation
Walkthrough这次更新主要针对 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- cmake/braft.cmake (2 hunks)
- cmake/brpc.cmake (2 hunks)
Additional comments not posted (5)
cmake/braft.cmake (2)
29-29
: 添加库路径配置新增的
-DCMAKE_LIBRARY_PATH=${LIB_INSTALL_PREFIX}
参数确保构建系统在安装阶段能够找到必要的库。
42-42
: 修正Protobuf库引用将参数
-DPROTOBUF_LIBRARIES=${PROTOBUF_LIBRARY}
修改为-DPROTOBUF_LIBRARY=${PROTOBUF_LIBRARY}
,简化或修正了库链接的变量命名。cmake/brpc.cmake (3)
27-27
: 添加库路径配置新增的
-DCMAKE_LIBRARY_PATH=${LIB_INSTALL_PREFIX}
参数确保构建系统在安装阶段能够找到必要的库。
38-38
: 修正Protobuf库引用将参数
-DPROTOBUF_LIBRARIES=${PROTOBUF_LIBRARY}
修改为-DProtobuf_LIBRARIES=${PROTOBUF_LIBRARY}
,简化或修正了库链接的变量命名。
40-40
: 修正Protobuf包含目录引用将参数
-DPROTOBUF_INCLUDE_DIRS=${PROTOBUF_INCLUDE_DIR}
修改为-DProtobuf_INCLUDE_DIR=${PROTOBUF_INCLUDE_DIR}
,简化或修正了包含目录的变量命名。
修复protobuf多本版共存导致的链接错误
之前,如果本地安装了protobuf,然后编译pikiwidb,在链接时,会使用系统的protobuf, 导致链接出错,现在支持如果本地已经安装了protobuf,在编译和链接时,不使用系统的,防止链接出错
leveldb会自动搜索当前系统中是否存在 snappy , 如果存在就会自动加入, 并且不可关闭这个选项, 现在对 leveldb 加入了 snappy支持, 使用项目中的 snappy
Summary by CodeRabbit
新特性
修复问题