Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add list cmd lset and go ut #141

Closed
wants to merge 7 commits into from

Conversation

578223592
Copy link
Collaborator

@578223592 578223592 commented Jan 23, 2024

#30

问题请教结果:

那pikiwidb/src/common.cc里面有一些函数:IsValidNumber,TryStr2Long,Strtol,Strtoll甚至更多是不是没有存在的必要了
如果还没人使用,那就删了
  • pikiwidb/src/common.cc里面有一些函数:IsValidNumber,TryStr2Long,Strtol,Strtoll 考虑删除,其中Strtoll 没有使用,已经删除,Strtol使用地方有十几处,暂时没删除。
  • 对set相关的命令添加一些测试,测试下对于0x、0b开头的数据是否有影响,新开一个pr feat:add different base test #152

@github-actions github-actions bot added the ✏️ Feature New feature or request label Jan 23, 2024
src/cmd_list.cc Outdated Show resolved Hide resolved
@578223592 578223592 marked this pull request as draft January 24, 2024 07:49
@578223592 578223592 marked this pull request as ready for review January 28, 2024 13:29
@panlei-coder
Copy link
Collaborator

解决一下冲突

@578223592
Copy link
Collaborator Author

合并到#150 一起完成了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants