feat:import braft #130
Merged
feat:import braft #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: import braft * fix: fix braft.cmake * fix:fix import braft cmake * fix: fix fetchcontent_populate * fix: fix find gflags brpc braft cmake * add independent code and fix brpc * fix: delete unnecessary comments * fix: fix fetch content to ExternalProject_Add * fix: add counter.pb.h and counter.pb.cc --------- Co-authored-by: century <[email protected]>
…ation#134) * feat: import braft * fix: fix braft.cmake * fix:fix import braft cmake * fix: fix fetchcontent_populate * fix: fix find gflags brpc braft cmake * add independent code and fix brpc * fix: delete unnecessary comments * fix: fix fetch content to ExternalProject_Add * fix: add counter.pb.h and counter.pb.cc * fix: fixed a bug where the compiler could not find glog --------- Co-authored-by: century <[email protected]>
|
|
|
在docker环境里这个CPU个数好像是不对的，会导致make并发数很大。 |
|
引入braft到counter模块之外模块的问题 |
* fix:fixed a bug that included braft
panlei-coder
force-pushed
the
import-braft
branch
2 times, most recently
from
a64e4ca to
fbc8b0c
Compare
…omFoundation#180) fix:Synchronize the latest changes to the import-braft branch
AlexStocks
reviewed
Feb 29, 2024
AlexStocks
reviewed
Feb 29, 2024
AlexStocks
reviewed
Feb 29, 2024
AlexStocks
reviewed
Feb 29, 2024
AlexStocks
reviewed
Feb 29, 2024
AlexStocks
reviewed
Feb 29, 2024
AlexStocks
reviewed
Feb 29, 2024
longfar-ncy
reviewed
Feb 29, 2024
src/counter/counter.pb.cc
Outdated
| @@ -0,0 +1,996 @@ | |||
| // Generated by the protocol buffer compiler. DO NOT EDIT! | |||
There was a problem hiding this comment.
这个不应该被ignore掉嘛？怎么还能提交上来
There was a problem hiding this comment.
没啥问题了 整个文件夹都会删掉 单纯的做验证引入是否正确用的
hotjump
reviewed
Mar 2, 2024
cmake/braft.cmake
Outdated
| SET(BRAFT_INCLUDE_DIR "${BRAFT_INSTALL_DIR}/include" CACHE PATH "braft include directory." FORCE) | ||
| SET(BRAFT_LIBRARIES "${BRAFT_INSTALL_DIR}/lib/libbraft.a" CACHE FILEPATH "braft library." FORCE) | ||
|
|
||
| SET(NUM_OF_PROCESSOR 1) |
There was a problem hiding this comment.
pikiwidb里的cmake有一个代码是获取cpu核数的，可以复用那个代码。只用一个cpu编译会比较慢。
hotjump
reviewed
Mar 2, 2024
tests/hash_test.go
Outdated
| @@ -12,7 +12,7 @@ import ( | |||
| "log" | |||
| "strconv" | |||
| "time" | |||
|
|
|||
dingxiaoshuai123
previously approved these changes
Mar 6, 2024
longfar-ncy
previously approved these changes
Mar 6, 2024
dingxiaoshuai123
dismissed stale reviews from longfar-ncy and themself
The base branch was changed.
dingxiaoshuai123
merged commit 973b426
into
OpenAtomFoundation:import-braft
8 checks passed
dingxiaoshuai123
added a commit
to dingxiaoshuai123/pikiwidb
that referenced
this pull request
Mar 25, 2024
* feat: import braft --------- Co-authored-by: century <[email protected]> Co-authored-by: alexstocks <[email protected]> Co-authored-by: dingxiaoshuai123 <[email protected]>
AlexStocks
added a commit
that referenced
this pull request
May 6, 2024
* feat:import braft (#130) * feat: Implementing Redis-Raft commands to build a cluster. (#136) Co-authored-by: panlei-coder <[email protected]> Co-authored-by: century <[email protected]> Co-authored-by: panlei-coder <[email protected]> Co-authored-by: alexstocks <[email protected]> Co-authored-by: dingxiaoshuai123 <[email protected]> Co-authored-by: longfar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import the third-party library braft，目前是把braft的example的counter文件夹直接copy到了pikiwidb/src目录下作为子文件夹编译的，主要是为了验证braft引入的正确性，后面合并的时候会删除掉