Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RsyncClient::ThreadMain函数中未关闭打开的文件。且更新文件的方法不正确 #2302

Closed
chengyu-l opened this issue Jan 12, 2024 · 0 comments
Closed

RsyncClient::ThreadMain函数中未关闭打开的文件。且更新文件的方法不正确 #2302

chengyu-l opened this issue Jan 12, 2024 · 0 comments
Labels
☢️ Bug Something isn't working

Comments

@chengyu-l
Copy link
Contributor

Is this a regression?

Yes

Description

RsyncClient::ThreadMain函数中未关闭打开的文件。且更新文件的方法不正确，正确做法应该是先写临时文件，然后覆盖旧文件。这里的修改方式存在的问题是：写文件到一半，服务器断电，可能会导致文件内容不符合预期。

image

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response
@chengyu-l chengyu-l added the ☢️ Bug Something isn't working label Jan 12, 2024
chengyu-l pushed a commit to chengyu-l/pika that referenced this issue Jan 13, 2024
fix: RsyncClient::ThreadMain not close file(OpenAtomFoundation#2302)
6a7d441
@chengyu-l chengyu-l mentioned this issue Jan 13, 2024
Merged
AlexStocks pushed a commit that referenced this issue Jan 13, 2024
@chengyu-l
fix: RsyncClient::ThreadMain not close file(#2302) (#2313)
8b0c4dc 
Co-authored-by: liuchengyu <[email protected]>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this issue Jun 8, 2024
@chengyu-l
fix: RsyncClient::ThreadMain not close file(OpenAtomFoundation#2302) (O…
ba1ff7a 
…penAtomFoundation#2313)

Co-authored-by: liuchengyu <[email protected]>
cheniujh pushed a commit to cheniujh/pika that referenced this issue Sep 24, 2024
@chengyu-l
fix: RsyncClient::ThreadMain not close file(OpenAtomFoundation#2302) (O…
0c960b0 
…penAtomFoundation#2313)

Co-authored-by: liuchengyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexStocks @chengyu-l