This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Add commands for annepro2_shine profiles #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2020 23:31
|
Thanks for your effort anyways 😄 |
You should merge #5, tech2077s implementation is much better than mine |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAnnePro/AnnePro2-Shine@9202d03
The commit above added commands in annepro2_shine that allows for switching led profiles.
I added commands for the qmk firmware to work with the new commands.
This is my first pull request, please correct me if I'm doing something wrong.
I'm gonna add the bidirectional communication later because I'm not good at it yet.