Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci scripts to run the app after build #709

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

KIRA009
Copy link
Contributor

@KIRA009 KIRA009 commented Jun 5, 2024

What kind of change does this PR introduce?
This PR introduces simple scripts that runs the built app in the CI and checks if the app is able to run without issues

Summary
This PR adds CI scripts that download the built apps for each platform, run them, and after an interval, check if the processes are still running. The app code is designed such that any exceptions, the app will exit gracefully, and so the script will not be able to find the process running, and accordingly raise the error.

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

You can create an invalid build (by raising Exceptions, or commenting out packages from the build.py) and push to your fork (make sure to change the on condition on release-and-publish.yml to any branch (**))

Copy link
Member

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KIRA009 thanks for putting this together! Just one small comment.

openadapt/entrypoint.py Outdated Show resolved Hide resolved
Copy link
Member

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abrichr abrichr merged commit e370fe6 into OpenAdaptAI:main Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants