Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add preview option to black pre-commit hook and update README #405

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

Mustaballer
Copy link
Collaborator

@Mustaballer Mustaballer commented Jul 18, 2023

What kind of change does this PR introduce?

Add --preview flag to python black pre-commit hook, and update README.md on black pre-commit hook.

Summary

We want to use future python black formatting as mentioned here.

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

Run pre-commit install to update pre-commit hooks and test when staging files that need formatting changes.

- repo: https://github.com/pycqa/isort
rev: 5.12.0
hooks:
- id: isort
name: isort (python)
args: ["--profile", "black"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because it is already specified in pyproject.toml

@Mustaballer Mustaballer requested a review from abrichr July 18, 2023 20:56
@abrichr abrichr merged commit 6a42eb7 into OpenAdaptAI:main Jul 19, 2023
R-ohit-B-isht pushed a commit to R-ohit-B-isht/OpenAdapt that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants