Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: configure isort with black profile and add black precommit hook #384

Merged
merged 3 commits into from
Jul 17, 2023
Merged

chore: configure isort with black profile and add black precommit hook #384

merged 3 commits into from
Jul 17, 2023

Conversation

Mustaballer
Copy link
Collaborator

@Mustaballer Mustaballer commented Jul 14, 2023 •
edited
Loading

What kind of change does this PR introduce?

Configure isort with black profile and add black as a pre commit hook

Summary

Address comment #367 (comment)

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

Other information

@Mustaballer Mustaballer marked this pull request as draft July 14, 2023 02:48
@Mustaballer Mustaballer marked this pull request as ready for review July 14, 2023 16:19
@Mustaballer Mustaballer requested a review from abrichr July 14, 2023 16:19
@Mustaballer Mustaballer mentioned this pull request Jul 14, 2023
Merged
7 tasks
@Mustaballer
Copy link
Collaborator Author

@abrichr Ready for Review! I ran this custom isort on all files in #289. It follows our modifed import style that is specified in CONTRIBUTING.md.

You can check the commit here.

@abrichr abrichr merged commit 2e7496b into OpenAdaptAI:main Jul 17, 2023
R-ohit-B-isht pushed a commit to R-ohit-B-isht/OpenAdapt that referenced this pull request Jun 21, 2024
@Mustaballer
chore: configure isort with black profile and add black precommit hook (
ce67433 
OpenAdaptAI#384)

* chore: configure isort with black profile and add black precommit hook

* update black version

* add advanced isort settings to match CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrichr abrichr Awaiting requested review from abrichr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mustaballer @abrichr