fix: windows.get_active_window() #333

jesicasusanto · 2023-06-30T05:57:26Z

What kind of change does this PR introduce?

This PR changes the _windows.get_active_window_state() in https://github.com/OpenAdaptAI/OpenAdapt/blob/main/openadapt/window/_windows.py#L31 , to get the top window of the active application. This PR resolves getting the "No windows of that application are active" logger wawrning.

Summary

This PR is a bugfix for #331.

Checklist

My code follows the style guidelines of OpenAdapt
I have perfomed a self-review of my code
If applicable, I have added tests to prove my fix is functional/effective
I have linted my code locally prior to submission
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
New and existing unit tests pass locally with my changes

How can your code be run and tested?

Create a new recording on windows, switch to a different application. You should not see the "No windows of that application are active" warning again.

jesicasusanto · 2023-06-30T06:29:25Z

Result of bugfix :

bugfix.331.-.Made.with.Clipchamp.mp4

abrichr · 2023-06-30T15:23:01Z

openadapt/window/_windows.py

-    except RuntimeError as e:
-        logger.warning(e)
-        return {}
+    active_window = get_active_window()


Please handle exception 🙏

abrichr · 2023-07-06T13:58:58Z

openadapt/window/_windows.py

@@ -28,7 +28,6 @@ def get_active_window_state() -> dict:
    try:
        active_window = get_active_window()
    except RuntimeError as e:
-        logger.warning(e)


Thanks @jesicasusanto !

Can you please clarify why this was removed?

cr-gpt · 2023-07-11T13:52:00Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2023-07-12T02:19:38Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

…returns-None-and-logs-error

cr-gpt · 2023-07-12T02:32:24Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2023-07-12T02:32:26Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

jesicasusanto · 2023-07-12T10:19:02Z

address *** _ctypes.COMError: (-2147467263, 'Not implemented', (None, None, None, 0, None)) error
This error is reproduced by getting the selection_indices() property from a <uia_controls.EditWrapper - 'Address and search bar', Edit, -4439357938799333343> element in 3dc81e5

ipdb> getattr(element, propname)()
*** _ctypes.COMError: (-2147467263, 'Not implemented', (None, None, None, 0, None))
ipdb> element
<uia_controls.EditWrapper - 'Address and search bar', Edit, -4439357938799333343>
ipdb> propname
'selection_indices'

address *** NotImplementedError: This method not work properly for WinForms DataGrid, use cells()
ipdb> getattr(element, propname)() in 3dc81e5

*** NotImplementedError: This method not work properly for WinForms DataGrid, use cells()
ipdb> element
<uia_controls.ListViewWrapper - '', Table, -2863142914305943712>
ipdb> propname
'column_count'

…rror' of https://github.com/jesicasusanto/PAT into fix---windows.get_active_window-returns-None-and-logs-error

cr-gpt · 2023-07-12T10:24:05Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2023-07-12T17:52:10Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

abrichr · 2023-07-14T18:16:52Z

openadapt/window/_windows.py

+    """
+    _element_class = element.__class__
+    class TempElement(element.__class__):
+            writable_props = pywinauto.base_wrapper.BaseWrapper.writable_props


Please fix indent

abrichr · 2023-07-14T18:17:03Z

openadapt/window/_windows.py

+    return properties
+
+
+


Please remove extra newline

addressed in 6685c36

abrichr · 2023-07-17T14:50:42Z

Excellent, thank you @jesicasusanto !! 🙏

* return top_window of the active app * remove runtime exception * handle runtime error * handle COMerror * add logger.warning * add logger.warning * add get_properties * remove unnecessary imports * remove -> Desktop * monkey patching * fix get_properties * monkey patch __class__ * fix monkey patching * format with black

jesicasusanto added 2 commits June 30, 2023 12:49

return top_window of the active app

f8cdc9b

remove runtime exception

422ea18

jesicasusanto requested a review from abrichr June 30, 2023 05:57

jesicasusanto changed the title ~~return top_window of the active app~~ fix windows.get_active_window() Jun 30, 2023

jesicasusanto mentioned this pull request Jun 30, 2023

System tray state machine #290

Open

7 tasks

Mustaballer changed the title ~~fix windows.get_active_window()~~ fix: windows.get_active_window() Jun 30, 2023

abrichr reviewed Jun 30, 2023

View reviewed changes

handle runtime error

84e0295

abrichr mentioned this pull request Jul 4, 2023

[Bug]: windows.get_active_window returns None and logs error #331

Open

handle COMerror

a40bdb8

abrichr reviewed Jul 6, 2023

View reviewed changes

jesicasusanto added 3 commits July 10, 2023 09:05

add logger.warning

dafbd70

add logger.warning

5bbc2f3

add get_properties

3dc81e5

remove unnecessary imports

2769166

Merge branch 'OpenAdaptAI:main' into fix---windows.get_active_window-…

20cecf1

…returns-None-and-logs-error

jesicasusanto added 2 commits July 12, 2023 06:23

remove -> Desktop

faa3ec8

Merge branch 'fix---windows.get_active_window-returns-None-and-logs-e…

a89a4d3

…rror' of https://github.com/jesicasusanto/PAT into fix---windows.get_active_window-returns-None-and-logs-error

monkey patching

5890012

jesicasusanto added 3 commits July 13, 2023 10:49

fix get_properties

29e749b

monkey patch __class__

02e2373

fix monkey patching

cc0eb4b

abrichr reviewed Jul 14, 2023

View reviewed changes

format with black

6685c36

abrichr merged commit d3f07c9 into OpenAdaptAI:main Jul 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: windows.get_active_window() #333

fix: windows.get_active_window() #333

jesicasusanto commented Jun 30, 2023

jesicasusanto commented Jun 30, 2023

abrichr Jun 30, 2023

abrichr Jul 6, 2023

cr-gpt bot commented Jul 11, 2023

cr-gpt bot commented Jul 12, 2023

cr-gpt bot commented Jul 12, 2023

cr-gpt bot commented Jul 12, 2023

jesicasusanto commented Jul 12, 2023

cr-gpt bot commented Jul 12, 2023

cr-gpt bot commented Jul 12, 2023

abrichr Jul 14, 2023

abrichr Jul 14, 2023

jesicasusanto Jul 14, 2023

abrichr commented Jul 17, 2023

fix: windows.get_active_window() #333

fix: windows.get_active_window() #333

Conversation

jesicasusanto commented Jun 30, 2023

jesicasusanto commented Jun 30, 2023

abrichr Jun 30, 2023

Choose a reason for hiding this comment

abrichr Jul 6, 2023

Choose a reason for hiding this comment

cr-gpt bot commented Jul 11, 2023

cr-gpt bot commented Jul 12, 2023

cr-gpt bot commented Jul 12, 2023

cr-gpt bot commented Jul 12, 2023

jesicasusanto commented Jul 12, 2023

cr-gpt bot commented Jul 12, 2023

cr-gpt bot commented Jul 12, 2023

abrichr Jul 14, 2023

Choose a reason for hiding this comment

abrichr Jul 14, 2023

Choose a reason for hiding this comment

jesicasusanto Jul 14, 2023

Choose a reason for hiding this comment

abrichr commented Jul 17, 2023