-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds hasRequired to all Java schema classes #8962
Merged
spacether
merged 14 commits into
OpenAPITools:master
from
spacether:adds_hasRequiredVars
Mar 19, 2021
Merged
Adds hasRequired to all Java schema classes #8962
spacether
merged 14 commits into
OpenAPITools:master
from
spacether:adds_hasRequiredVars
Mar 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
The circleci DartDioPetstoreClientLibFakeTests is unrelated to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds hasRequired to all Java schema classes
@wing328
This is needed if one is generating classes for object schemas and one only wants to generate the class if required exists.
One could almost do this with #requiredVars but that doesn't work because using #requiredVars mean we move into the context of iterating over each var when we just need to know if there are required vars.
hasRequired is tested in the below models:
These tests show that hasRequired (and requiredVars) sometime loose the schema required information as shown in
#8906
This PR came out of work in #8928
This will be used in:
#8325
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x