Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hasRequired to all Java schema classes #8962

Merged
merged 14 commits into from
Mar 19, 2021

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Mar 12, 2021

Adds hasRequired to all Java schema classes
@wing328

This is needed if one is generating classes for object schemas and one only wants to generate the class if required exists.
One could almost do this with #requiredVars but that doesn't work because using #requiredVars mean we move into the context of iterating over each var when we just need to know if there are required vars.

hasRequired is tested in the below models:

  • CodegenModel
  • CodegenProperty
  • CodegenParameter
  • CodegenResponse

These tests show that hasRequired (and requiredVars) sometime loose the schema required information as shown in
#8906

This PR came out of work in #8928

This will be used in:
#8325

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether marked this pull request as draft March 12, 2021 18:30
@spacether spacether marked this pull request as ready for review March 19, 2021 03:40
@spacether
Copy link
Contributor Author

The circleci DartDioPetstoreClientLibFakeTests is unrelated to this change

@spacether spacether merged commit a925c76 into OpenAPITools:master Mar 19, 2021
@spacether spacether deleted the adds_hasRequiredVars branch March 19, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant