Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractKotlinCodegen.java
has some issues related to date types.The first one is that in the
typeMapping
it definesDate
asjava.time.LocalDate
which is correct.But then in
importMapping
it definesDate
asjava.time.LocalDate
which is incorrect and doesn't match with thetypeMapping
It should define
Date
asjava.time.LocalDate
in thetypeMapping
.The second one is that it defines
DateTime
asjava.time.LocalDateTime
in thetypeMapping
and in theimportMapping
, which is wrong, it should bejava.time.OffsetDateTime
.This can cause bugs because the servers and the clients can (and most probably are) in different timezones.
This is already fixed in
KotlinSpringServerCodegen
andKotlinClientCodegen
but not inAbstractKotlinCodegen
.Finally since
java.util.Date
is never used, it's not necessary in the Kotlin ClientSerializer
, so it's removed.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)