[GO][Client] return GenericOpenAPIError instead of error in Execute()

[code-lucidal58]

fix #8136

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

[code-lucidal58]

Code snippet used to test the generated client code

result, _, err := r.Execute()
if err.Error() != "" {
	return fmt.Errorf("error occurred while updating object: %s Response: %s", err.Error(), string(err.Body()))
}

Output:

Error: error occurred while updating VnicEthIf object: 400 Bad Request Response: <response body as it is >

Earlier Output:

Error: error occurred while updating VnicEthIf object: 400 Bad Request Response: 

When printing the error err only because error does not support .Body(), GenerateOpenAPIError does.

[wing328]

@code-lucidal58 what about using tabs instead of 4-spaces for this line and some other lines below?

[code-lucidal58]

I use tabs. And looks fine in Atom and Intellij. Not sure why it looks different here. Let me try again

[code-lucidal58]

done

[wing328]

Looks like there are syntax errors causing build failure:

# _/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go/go-petstore
go-petstore/api_another_fake.go:95:2: syntax error: non-declaration statement outside function body
FAIL	_/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go [build failed]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (go-test) on project GoPetstore: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]

[code-lucidal58]

All errors fixed @wing328

[code-lucidal58]

Not able to figure out why the circleci build fails.

[wing328]

I think you will need to update the test as well. Here is the error reported by the CI:

Download https://repo1.maven.org/maven2/org/junit/platform/junit-platform-engine/1.4.0/junit-platform-engine-1.4.0.jar
Download https://repo1.maven.org/maven2/org/junit/jupiter/junit-jupiter-api/5.4.0/junit-jupiter-api-5.4.0.jar
Download https://repo1.maven.org/maven2/org/junit/platform/junit-platform-commons/1.4.0/junit-platform-commons-1.4.0.jar
:processResources UP-TO-DATE
:classes
:compileTestJava UP-TO-DATE
:compileTestGroovy
:processTestResources UP-TO-DATE
:testClasses
:test

BUILD SUCCESSFUL

Total time: 22.356 secs
# _/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go/mock
mock/mock_api_pet.go:20:29: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:28:32: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:36:39: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:44:37: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:52:33: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:60:32: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:68:40: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:76:33: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:84:49: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
FAIL	_/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go [build failed]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (go-test) on project GoPetstore: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :GoPetstore
2020-12-13 15:52:05.344:INFO::main: Logging initialized @106ms

[wing328]

All tests passed. If no further feedback/question from anyone, I'll merge it on coming Wed.