[dart-dio] Serializes request bodies using a specific serializer #6384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josh-burton What is missing to get this merged? |
josh-burton
force-pushed
the
dart-dio-serialize-type
branch
from
abbf0d7 to
f96b90b
Compare
|
I think CI is failing because of outdated samples, but I'm not sure how to generate new samples as the process seems to have changed. |
josh-burton
force-pushed
the
dart-dio-serialize-type
branch
from
72a7a06 to
b16d4b1
Compare
kuhnroyal
reviewed
Dec 8, 2020
| @@ -126,7 +128,9 @@ class FakeApi { | |||
| List<String> contentTypes = ["application/json"]; | |||
|
|
|||
|
|
|||
| var serializedBody = _serializers.serialize(body); | |||
|
|
|||
| var bodySerializer = _serializers.serializerForType(bool); | |||
There was a problem hiding this comment.
Does this work or does this need extra handling for primitives?
There was a problem hiding this comment.
After looking at the StandardJsonPlugin, I think this needs special handling for primitives. Probably a plain jsonEncode without any serializer?
|
Something went wrong with the merge :o |
josh-burton
force-pushed
the
dart-dio-serialize-type
branch
from
c068cec to
7843a77
Compare
|
@josh-burton Can you update again so we can merge this before monday? |
josh-burton
force-pushed
the
dart-dio-serialize-type
branch
from
7843a77 to
c5e7cce
Compare
kuhnroyal
approved these changes
Dec 20, 2020
|
Travis CI failure not related to this change. |
kuhnroyal
added a commit
to kuhnroyal/openapi-generator
that referenced
this pull request
Jan 5, 2021
This happened due to the merge of OpenAPITools#6384 where implicit-dynamics were still allowed.
6 tasks
wing328
pushed a commit
that referenced
this pull request
Jan 5, 2021
This happened due to the merge of #6384 where implicit-dynamics were still allowed.
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serializes request bodies using a specific serializer so a discriminator is not added
When using the generic
serializemethod, built value will add a descriminator to the serialized json. For APIs with strict parsing, this causes parsing errors.By finding the specific serializer for the type built value omits the descriminator.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.CC: @ircecho @swipesight @jaumard @amondnet