dart-dio improvements #6047
Merged
dart-dio improvements #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-burton
reviewed
Apr 24, 2020
modules/openapi-generator/src/main/resources/dart-dio/api.mustache
Outdated
Show resolved
Hide resolved
|
If no further feedback on this PR, I'll merge it over the weekend. |
|
@jaumard thanks for the PR, which has been included in the v4.3.1 release: https://twitter.com/oas_generator/status/1258057660974329861 |
michaelpro1
pushed a commit
to michaelpro1/openapi-generator
that referenced
this pull request
May 7, 2020
* fix runtime deserialisation * add security support for dart dio * regenerate dart dio sample * update dio pubspec.mustache deps * check response type before parsing * add default dateTime serializer * regenerate sample
| @@ -88,12 +88,12 @@ class {{classname}} { | |||
|
|
|||
| {{#isListContainer}} | |||
| final FullType type = const FullType(BuiltList, const [const FullType({{returnBaseType}})]); | |||
| BuiltList<{{returnBaseType}}> dataList = _serializers.deserialize(jsonDecode(response.data), specifiedType: type); | |||
| BuiltList<{{returnBaseType}}> dataList = _serializers.deserialize(response.data is String ? jsonDecode(response.data) : response.data, specifiedType: type); | |||
There was a problem hiding this comment.
After this change, you cannot have a 'text/plain' response, as it tries to apply jsonDecode on it.
:(
There was a problem hiding this comment.
With 'text/plain' response you shouldn't arrived here as you don't need to deserialize at all
There was a problem hiding this comment.
Indeed, but it was trying to deserialize a text/plain response.
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
May 31, 2020
* fix runtime deserialisation * add security support for dart dio * regenerate dart dio sample * update dio pubspec.mustache deps * check response type before parsing * add default dateTime serializer * regenerate sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6044
fix #6026
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc @ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @nickmeinhold (2019/09) @athornz (2019/12) @amondnet (2019/12)