Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Optional colorized outputs #5193

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

jimschubert
Copy link
Member

Requested by @ybelenko in #4615

Trying this out: set -Dcolor

image

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert jimschubert added this to the 4.3.0 milestone Feb 2, 2020
@jimschubert jimschubert requested a review from ybelenko February 2, 2020 20:54
@auto-labeler
Copy link

auto-labeler bot commented Feb 2, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jimschubert jimschubert requested a review from wing328 February 2, 2020 20:58
Copy link
Contributor

@ybelenko ybelenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked locally, works as expected! I thought WARN level will be yellow, but it's not a deal breaker, at least I can see warnings in the mess of lines.

@jimschubert
Copy link
Member Author

Awesome. I'll merge and add a little to docs about usage.

cc @OpenAPITools/generator-core-team for visibility

@jimschubert jimschubert merged commit 97ff9b4 into OpenAPITools:master Feb 2, 2020
@jimschubert jimschubert deleted the colorized-output-cli branch February 2, 2020 22:36
@ybelenko
Copy link
Contributor

ybelenko commented Feb 2, 2020

@jimschubert You merged your own pull request? That's big no-no. I should call PR police right now. 😄

@jimschubert
Copy link
Member Author

tenor (1)

jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Feb 3, 2020
* master:
  [cli] Optional colorized outputs (OpenAPITools#5193)
  [bug] fix null pointer exception while evaluating recommend… (OpenAPITools#5191)
  [csharp-netcore] Improved `Multimap` and `ClientUtils` implementation (OpenAPITools#5122)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants