Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csharp): Fixed JsonConverter for discriminators only appearing on base classes #19972

Conversation

DaveK-Rocketmakers
Copy link
Contributor

@DaveK-Rocketmakers DaveK-Rocketmakers commented Oct 25, 2024

This fixes the issue mentioned in #17990.

The change was tested and applied using template overrides in the modelGeneric scenario. I updated all other references to this attribute as it should be causing the same issue.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@DaveK-Rocketmakers
Copy link
Contributor Author

As per final checklist - @mandrean @shibayan @Blackclaws @lucamazzanti @iBicha

@wing328
Copy link
Member

wing328 commented Oct 31, 2024

can you please update the samples when you've time so that the CI can test the change?

https://github.com/OpenAPITools/openapi-generator/actions/runs/11516147910/job/32323059416?pr=19972

@DaveK-Rocketmakers
Copy link
Contributor Author

I've updated the samples

@wing328 wing328 merged commit d9229c7 into OpenAPITools:master Nov 9, 2024
20 checks passed
@wing328
Copy link
Member

wing328 commented Nov 9, 2024

@DaveK-Rocketmakers thanks for the PR, which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants